Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(www/starters): Capitalize all tags #8693

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Oct 2, 2018

Fixing the capitalization of the tags (again). I missed one "Official" in my first run.
Peril should check that only capitalized tags get inserted: gatsbyjs/peril-gatsbyjs#41

Initially I wanted to fix two more issues:
18-10-02_8y63e

  • No scrolling for the Gatsby version
  • When you select a category the container gets smaller (I find that pretty annoying)

But I can't get www to work locally as I see this error in my terminal:

GraphQL Error Unknown field `allDependencies` on type `starterShowcase_2`

  file: C:/Users/Lennart/Documents/GitHub/gatsby/www/src/pages/starters.js

   8 |             starterShowcase {
   9 |               slug
  10 |               stub
  11 |               description
  12 |               stars
  13 |               lastUpdated
  14 |               owner
  15 |               name
  16 |               githubFullName
  17 |               gatsbyMajorVersion
> 18 |               allDependencies
     |               ^
  19 |               gatsbyDependencies
  20 |               miscDependencies
  21 |             }
  22 |           }
  23 |           url
  24 |           repo
  25 |           description
  26 |           tags
  27 |           features
  28 |           internal {

And this in my browser console:
Cannot read property 'allStartersYaml' of undefined & Cross-Origin Error

@fk fk merged commit f556349 into gatsbyjs:master Oct 2, 2018
@LekoArts LekoArts deleted the fix/starters branch October 2, 2018 12:17
@LekoArts
Copy link
Contributor Author

LekoArts commented Oct 2, 2018

@amberleyromo Do you know what's going on with the error I'm getting on www? 🤔

Solved.

@pieh
Copy link
Contributor

pieh commented Oct 2, 2018

Peril should check that only capitalized tags get inserted

That's good idea - we just need to adjust https://www.gatsbyjs.org/docs/submit-to-starter-library/ to mention that tags should be capitalized if we want to enforce that rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants