[Starter Library] make the ResetFilters div conditional #8923
Conversation
currently there is a div space there with a 3.5rem height even if no filters are selected. this looks ugly on first load:
|
Hey! This was actually added intentionally. Otherwise on the first selection, there's a weird jump as the space readjusts. This space at least has consistency with the header space to the right. |
|
PR convo, for context: #8743 |
|
ok :( |
|
incidentally, amberley, just before i left i thought we had a convo about removing the gatsby versions from all of the starter showcase. i started out very much for displaying gatsby versions, but then was convinced to change my mind. interesting that the final result seems to have done a 180 again! |
|
Thanks for your thoughtfulness about all this Shawn -- I really appreciate it! I think ideally we wouldn't have it, but with the very recent release of v2, we wanted it to be very clear (since most starters at this point were v1, we didn't want people to accidentally get started with a v1 starter and not know it, and then have to convert). Mostly to do with the proximity of the v2 release. |
|
that was what i said!!! lol |
currently there is a div space there with a 3.5rem height even if no filters are selected. this looks ugly on first load:
so my pr tries to fix that at the cost of a jump in the filters when filters are selected. i think that's ok to make the first load look better.