Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deploying-to-heroku.md #8721

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Add deploying-to-heroku.md #8721

merged 1 commit into from
Oct 2, 2018

Conversation

OrthoDex
Copy link
Contributor

@OrthoDex OrthoDex commented Oct 2, 2018 •
edited
Loading

Implements Deploying To Heroku in #8103

@OrthoDex OrthoDex requested a review from a team October 2, 2018 19:55
KyleAMathews
KyleAMathews approved these changes Oct 2, 2018
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KyleAMathews KyleAMathews merged commit ba5e255 into gatsbyjs:master Oct 2, 2018
@gatsbot
Copy link

gatsbot bot commented Oct 2, 2018

Holy buckets, @OrthoDex — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@shannonbux shannonbux mentioned this pull request Oct 3, 2018
Closed
51 tasks
lipis added a commit to lipis/gatsby that referenced this pull request Oct 3, 2018
@lipis
Merge branch 'master' of github.com:gatsbyjs/gatsby into hooks
427af33 
* 'master' of github.com:gatsbyjs/gatsby: (72 commits)
  fix: fix wording in plopfile (gatsbyjs#8735)
  fix: navigateTo deprecation message (gatsbyjs#8745)
  Add deploying-to-heroku.md (gatsbyjs#8721)
  fix(docs): Link to instructions on adding to plugin library (gatsbyjs#8686)
  updated gatsby-plugin-remove-trailing-slashes docs to include link re… (gatsbyjs#8720)
  feat(www/starters): Add TypeScript and Contentful starter (gatsbyjs#8704)
  fix(docs): fix typos in template doc (gatsbyjs#8692)
  feat(www): change chevron direction on sticky responsive sidebar (gatsbyjs#8664)
  chore(release): Publish
  [integration] [cypress-gatsby] feat: Add Gatsby API support to our Cypress plugin (gatsbyjs#8641)
  chore(release): Publish
  fix(gatsby): add mjs config to webpack and resolve correctly (gatsbyjs#8717)
  feat(gatsby-plugin-netlify): add force option to createRedirect (gatsbyjs#8521)
  [www/starters] tweaks to fix DX for no GH token on www (gatsbyjs#8718)
  chore(release): Publish
  fix(gatsby-dev-cli): infer correct prefix from package path (gatsbyjs#8683)
  fix(www/starters): fix broken link to submission instructions (gatsbyjs#8715)
  chore(release): Publish
  feat(gatsby) : add createContentDigest helper (gatsbyjs#8687)
  feat: publish SendGrid case study blogpost (gatsbyjs#8592)
  ...
@shannonbux shannonbux added type: documentation An issue or pull request for improving or updating Gatsby's documentation Hacktoberfest labels Oct 3, 2018
shannonbux added a commit that referenced this pull request Oct 19, 2018
@shannonbux
Delete doc since it was broken into smaller docs
6a9902c 
This is a proposal to delete this doc now that we have broken all the deployment options into separate docs and I just added them to the sidebar. If this PR gets merged I'll also delete this doc from the sidebar.

Taken from #8103: 

### Deploying
- [x] Deploying to S3/Cloudfront
- [x] Deploying to Netlify
- [x] Deploying to Aerobatic #8736
- [x] Deploying to Heroku #8721 (PR)
- [x] Deploying to Now #8737
- [x] Deploying to GitLab Pages #8738
@shannonbux shannonbux mentioned this pull request Oct 19, 2018
Merged
6 tasks
shannonbux added a commit that referenced this pull request Oct 22, 2018
@shannonbux
Delete doc since it was broken into smaller docs (#9262)
5de6815 
This is a proposal to delete this doc now that we have broken all the deployment options into separate docs and I just added them to the sidebar (commit 1af244b). If this PR gets merged I'll also delete this doc from the sidebar.

Taken from #8103: 

### Deploying
- [x] Deploying to S3/Cloudfront
- [x] Deploying to Netlify
- [x] Deploying to Aerobatic #8736
- [x] Deploying to Heroku #8721 (PR)
- [x] Deploying to Now #8737
- [x] Deploying to GitLab Pages #8738

<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@shannonbux @gpetrioli
Delete doc since it was broken into smaller docs (gatsbyjs#9262)
fb179fd 
This is a proposal to delete this doc now that we have broken all the deployment options into separate docs and I just added them to the sidebar (commit gatsbyjs@1af244b). If this PR gets merged I'll also delete this doc from the sidebar.

Taken from gatsbyjs#8103: 

### Deploying
- [x] Deploying to S3/Cloudfront
- [x] Deploying to Netlify
- [x] Deploying to Aerobatic gatsbyjs#8736
- [x] Deploying to Heroku gatsbyjs#8721 (PR)
- [x] Deploying to Now gatsbyjs#8737
- [x] Deploying to GitLab Pages gatsbyjs#8738

<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAMathews KyleAMathews KyleAMathews approved these changes

Assignees
No one assigned
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OrthoDex @KyleAMathews @shannonbux