Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby) : add createContentDigest helper #8687

Merged
merged 7 commits into from
Oct 2, 2018
Merged

feat(gatsby) : add createContentDigest helper #8687

merged 7 commits into from
Oct 2, 2018

Conversation

rbadr
Copy link
Contributor

@rbadr rbadr commented Oct 1, 2018

This PR add a createContentDigest helper and pass it in to the Gatsby API runner.

Closes #8587

@rbadr rbadr requested a review from a team as a code owner October 1, 2018 22:21
@rbadr rbadr requested a review from a team October 1, 2018 22:21
@rbadr rbadr mentioned this pull request Oct 1, 2018
Closed
DSchau
DSchau approved these changes Oct 1, 2018
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Left a small comment that I hope you can address :)

packages/gatsby/src/utils/__tests__/create-content-digest.js Outdated Show resolved Hide resolved
@KyleAMathews
Copy link
Contributor

Oops didn't mean to resolve that discussion. Can't seem to unresolve it from my phone.

Also, we should move some at least of the plugins over to use this to further test that this change is working correctly plus show real world examples of using it.

shannonbux
shannonbux reviewed Oct 2, 2018
View reviewed changes
Copy link
Contributor

@shannonbux shannonbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think as soon as we can verify that this change works for various source plugins, and this is a good change (I don't have the technical expertise to know ;) then the edits look good to me!

@rbadr
Copy link
Contributor Author

rbadr commented Oct 2, 2018

Also, we should move some at least of the plugins over to use this to further test that this change is working correctly plus show real world examples of using it.

@KyleAMathews With which plugin should we start ?

@KyleAMathews
Copy link
Contributor

It doesn't matter which ones. Just pick 3-4 at random and make the change. We'll actually pick ones with good tests to make sure the change doesn't have any effect on the plugin tests.

@rbadr
Copy link
Contributor Author

rbadr commented Oct 2, 2018

@KyleAMathews I choosed the one's with good tests. Tell me if I missed something :) Thanks

@rbadr
Copy link
Contributor Author

rbadr commented Oct 2, 2018

The travis ci is failing, did I miss something ?

@pieh
Copy link
Contributor

pieh commented Oct 2, 2018

The travis ci is failing, did I miss something ?

Travis is flaky sometimes - don't worry about that

DSchau
DSchau reviewed Oct 2, 2018
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, but this is looking good!

packages/gatsby/src/utils/create-content-digest.js Outdated Show resolved Hide resolved
DSchau
DSchau approved these changes Oct 2, 2018
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thank you for the PR 🎉

@DSchau DSchau merged commit e8b2696 into gatsbyjs:master Oct 2, 2018
@gatsbot
Copy link

gatsbot bot commented Oct 2, 2018

Holy buckets, @rbadr — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@DSchau
Copy link
Contributor

DSchau commented Oct 2, 2018 

Successfully published:
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

[email protected] is the important one here :)

lipis added a commit to lipis/gatsby that referenced this pull request Oct 3, 2018
@lipis
Merge branch 'master' of github.com:gatsbyjs/gatsby into hooks
427af33 
* 'master' of github.com:gatsbyjs/gatsby: (72 commits)
  fix: fix wording in plopfile (gatsbyjs#8735)
  fix: navigateTo deprecation message (gatsbyjs#8745)
  Add deploying-to-heroku.md (gatsbyjs#8721)
  fix(docs): Link to instructions on adding to plugin library (gatsbyjs#8686)
  updated gatsby-plugin-remove-trailing-slashes docs to include link re… (gatsbyjs#8720)
  feat(www/starters): Add TypeScript and Contentful starter (gatsbyjs#8704)
  fix(docs): fix typos in template doc (gatsbyjs#8692)
  feat(www): change chevron direction on sticky responsive sidebar (gatsbyjs#8664)
  chore(release): Publish
  [integration] [cypress-gatsby] feat: Add Gatsby API support to our Cypress plugin (gatsbyjs#8641)
  chore(release): Publish
  fix(gatsby): add mjs config to webpack and resolve correctly (gatsbyjs#8717)
  feat(gatsby-plugin-netlify): add force option to createRedirect (gatsbyjs#8521)
  [www/starters] tweaks to fix DX for no GH token on www (gatsbyjs#8718)
  chore(release): Publish
  fix(gatsby-dev-cli): infer correct prefix from package path (gatsbyjs#8683)
  fix(www/starters): fix broken link to submission instructions (gatsbyjs#8715)
  chore(release): Publish
  feat(gatsby) : add createContentDigest helper (gatsbyjs#8687)
  feat: publish SendGrid case study blogpost (gatsbyjs#8592)
  ...
@DSchau DSchau mentioned this pull request Oct 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shannonbux shannonbux shannonbux left review comments

@pieh pieh pieh left review comments

@KyleAMathews KyleAMathews KyleAMathews left review comments

@DSchau DSchau DSchau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rbadr @KyleAMathews @pieh @DSchau @shannonbux