Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to include a plugin in the Plugin Library #8686

Merged
merged 2 commits into from
Oct 2, 2018
Merged

How to include a plugin in the Plugin Library #8686

merged 2 commits into from
Oct 2, 2018

Conversation

conradj
Copy link
Contributor

@conradj conradj commented Oct 1, 2018 •
edited
Loading

Add some info on how to make your plugin available in the library, once it is published

@conradj conradj requested a review from a team October 1, 2018 21:49
@gatsbot
Copy link

gatsbot bot commented Oct 1, 2018

@conradj We noticed that the body of this issue is blank.

Please fill in this field with more information to help the maintainers resolve your issue.

Generated by 🚫 dangerJS

shannonbux
shannonbux previously requested changes Oct 2, 2018
View reviewed changes
amberleyromo
amberleyromo previously approved these changes Oct 2, 2018
View reviewed changes
Copy link
Contributor

@amberleyromo amberleyromo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • notes not to publish the sample plugin
  • links out to doc about publishing to the plugin library

thanks! 👍

@amberleyromo amberleyromo dismissed stale reviews from shannonbux and themself October 2, 2018 21:19

changes made

amberleyromo
amberleyromo approved these changes Oct 2, 2018
View reviewed changes
Copy link
Contributor

@amberleyromo amberleyromo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(accidentally dismissed the wrong review)

@amberleyromo amberleyromo merged commit db5390d into gatsbyjs:master Oct 2, 2018
@gatsbot
Copy link

gatsbot bot commented Oct 2, 2018

Holy buckets, @conradj — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

lipis added a commit to lipis/gatsby that referenced this pull request Oct 3, 2018
@lipis
Merge branch 'master' of github.com:gatsbyjs/gatsby into hooks
427af33 
* 'master' of github.com:gatsbyjs/gatsby: (72 commits)
  fix: fix wording in plopfile (gatsbyjs#8735)
  fix: navigateTo deprecation message (gatsbyjs#8745)
  Add deploying-to-heroku.md (gatsbyjs#8721)
  fix(docs): Link to instructions on adding to plugin library (gatsbyjs#8686)
  updated gatsby-plugin-remove-trailing-slashes docs to include link re… (gatsbyjs#8720)
  feat(www/starters): Add TypeScript and Contentful starter (gatsbyjs#8704)
  fix(docs): fix typos in template doc (gatsbyjs#8692)
  feat(www): change chevron direction on sticky responsive sidebar (gatsbyjs#8664)
  chore(release): Publish
  [integration] [cypress-gatsby] feat: Add Gatsby API support to our Cypress plugin (gatsbyjs#8641)
  chore(release): Publish
  fix(gatsby): add mjs config to webpack and resolve correctly (gatsbyjs#8717)
  feat(gatsby-plugin-netlify): add force option to createRedirect (gatsbyjs#8521)
  [www/starters] tweaks to fix DX for no GH token on www (gatsbyjs#8718)
  chore(release): Publish
  fix(gatsby-dev-cli): infer correct prefix from package path (gatsbyjs#8683)
  fix(www/starters): fix broken link to submission instructions (gatsbyjs#8715)
  chore(release): Publish
  feat(gatsby) : add createContentDigest helper (gatsbyjs#8687)
  feat: publish SendGrid case study blogpost (gatsbyjs#8592)
  ...
@shannonbux shannonbux added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh left review comments

@amberleyromo amberleyromo amberleyromo approved these changes

@shannonbux shannonbux shannonbux left review comments

Assignees
No one assigned
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@conradj @pieh @amberleyromo @shannonbux