allow cors request from react fetch #8660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I followed this tutorial and ran into errors with `.json` not being able to parse and `cors` being prevented because the client side wasn't allowing it (even though the server is allowing it).
pieh
reviewed
Oct 1, 2018
Don't worry about that - branch name suggestion is for you, so you can navigate your fork branches more easily - it doesn't affect us |
|
@gillkyle did you work on e-commerce tutorial? If so I would appreciate your review of this PR |
gillkyle
approved these changes
Oct 5, 2018
|
Holy buckets, @LukeSchlangen — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
|
Thank you! I love Gatsby! Happy to help even a little bit! |
lipis
added a commit
to lipis/gatsby
that referenced
this pull request
Oct 9, 2018
* 'master' of github.com:gatsbyjs/gatsby: (66 commits) Fixed typos and made styling changes (gatsbyjs#8938) fixed typo in migrating-from-v0-to-v1.md (gatsbyjs#8921) Add https://developer.bitcoin.com/ to the Site Showcase (gatsbyjs#8931) Remove code block (gatsbyjs#8930) test(gatsby-plugin-feed): don't snapshot test platform specific (gatsbyjs#8836) test: add gatsby-node tests for plugin manifest (gatsbyjs#8598) fix(docs): Fix typo in using-gatsby-image.md (gatsbyjs#8889) docs: Correcting code diff highlights (gatsbyjs#8913) docs: e-commerce tutorial - allow cors request from react fetch (gatsbyjs#8660) docs: Updated code diff highlighting (gatsbyjs#8914) fix(www): Correct wrong entries in sites + starters (gatsbyjs#8888) fix(docs): consistent links to other tutorial parts (gatsbyjs#8860) feat(docs): Create "Using Fragments" article (gatsbyjs#8902) Use title syntax on markdown code blocks (gatsbyjs#8912) chore: use createContentDigest helper (gatsbyjs#8813) Updated hyperlink (gatsbyjs#8856) [v2/starter] Gatsby v2 Starter based on Bulma (gatsbyjs#8884) docs: update Web App Manifest compat (gatsbyjs#8891) docs: fix gatsby-source-graphql README links (gatsbyjs#8886) docs: fix diff highlighting in StaticQuery example (gatsbyjs#8892) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed this tutorial and ran into errors with
.jsonnot being able to parse andcorsbeing prevented because the client side wasn't allowing it (even though the server is allowing it).I hope this is the right way to make a PR. I did it from clicking the links, so I apologize for the branch name being
patch-1