Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in using-gatsby-image.md #8889

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Fixed typo in using-gatsby-image.md #8889

merged 1 commit into from
Oct 8, 2018

Conversation

krismorf
Copy link
Contributor

@krismorf krismorf commented Oct 7, 2018

No description provided.

@krismorf krismorf requested a review from a team October 7, 2018 13:37
Copy link
Contributor

@amberleyromo amberleyromo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@@ -6,7 +6,7 @@ _Warning: gatsby-image is **not** a drop-in replacement for `<img />`. It’s op

[Demo](https://using-gatsby-image.gatsbyjs.org/)

`gatsby-images` incluedes the tricks you’d expect from a modern image component. It:
`gatsby-image` includes the tricks you’d expect from a modern image component. It:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof. Yep.

@@ -35,7 +35,7 @@ This isn’t ideal. Optimized images should be easy and the default.

With Gatsby, we can make images way way better.

`gatsby-image` is designed to work seamlessly with Gatsby’s native image processing capabilities powered by GraphQL and Sharp. To produce perfect images, you need only:
`gatsby-image` is designed to work seamlessly with Gatsby’s native image processing capabilities powered by GraphQL and Sharp. To produce perfect images, you only need to:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was fine either way tbh.

@amberleyromo amberleyromo merged commit 196c594 into master Oct 8, 2018
lipis added a commit to lipis/gatsby that referenced this pull request Oct 9, 2018
* 'master' of github.com:gatsbyjs/gatsby: (66 commits)
  Fixed typos and made styling changes (gatsbyjs#8938)
  fixed typo in migrating-from-v0-to-v1.md (gatsbyjs#8921)
  Add https://developer.bitcoin.com/ to the Site Showcase (gatsbyjs#8931)
  Remove code block (gatsbyjs#8930)
  test(gatsby-plugin-feed): don't snapshot test platform specific (gatsbyjs#8836)
  test: add gatsby-node tests for plugin manifest (gatsbyjs#8598)
  fix(docs): Fix typo in using-gatsby-image.md (gatsbyjs#8889)
  docs: Correcting code diff highlights (gatsbyjs#8913)
  docs: e-commerce tutorial - allow cors request from react fetch (gatsbyjs#8660)
  docs: Updated code diff highlighting (gatsbyjs#8914)
  fix(www): Correct wrong entries in sites + starters (gatsbyjs#8888)
  fix(docs): consistent links to other tutorial parts (gatsbyjs#8860)
  feat(docs): Create "Using Fragments" article (gatsbyjs#8902)
  Use title syntax on markdown code blocks (gatsbyjs#8912)
  chore: use createContentDigest helper (gatsbyjs#8813)
  Updated hyperlink (gatsbyjs#8856)
  [v2/starter] Gatsby v2 Starter based on Bulma (gatsbyjs#8884)
  docs: update Web App Manifest compat (gatsbyjs#8891)
  docs: fix gatsby-source-graphql README links (gatsbyjs#8886)
  docs: fix diff highlighting in StaticQuery example (gatsbyjs#8892)
  ...
@pieh pieh deleted the kmorf-patch-1 branch November 1, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants