Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Web App Manifest compat #8891

Merged
merged 2 commits into from
Oct 8, 2018
Merged

update Web App Manifest compat #8891

merged 2 commits into from
Oct 8, 2018

Conversation

tomByrer
Copy link
Contributor

@tomByrer tomByrer commented Oct 7, 2018

thanks for your resource

@tomByrer
update Web App Manifest compat
f4bdc15 
thanks for your resource
@tomByrer
Copy link
Contributor Author

tomByrer commented Oct 7, 2018

Updating CanIUse
Fyrd/caniuse#4534

HM100
HM100 approved these changes Oct 7, 2018 •
edited
Loading
View reviewed changes
LekoArts
LekoArts previously requested changes Oct 7, 2018
View reviewed changes
packages/gatsby-plugin-manifest/README.md Outdated
manifest is a JSON file that lets users (on Android Chrome, Firefox, and Opera —
[support in MS Edge & Safari is under development](http://caniuse.com/#feat=web-app-manifest))
manifest is a JSON file that lets users (on Chrome, Edge, Firefix, Safari Mobile, and Opera —
[support in and Safari Desktop is under development](http://caniuse.com/#feat=web-app-manifest))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"and" typo

@pieh pieh dismissed LekoArts’s stale review October 8, 2018 11:59

typo was fixed

pieh
pieh approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tomByrer!

@pieh pieh merged commit c9d9250 into gatsbyjs:master Oct 8, 2018
@gatsbot
Copy link

gatsbot bot commented Oct 8, 2018

Holy buckets, @tomByrer — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

lipis added a commit to lipis/gatsby that referenced this pull request Oct 9, 2018
@lipis
Merge branch 'master' of github.com:gatsbyjs/gatsby into hooks
5eb7833 
* 'master' of github.com:gatsbyjs/gatsby: (66 commits)
  Fixed typos and made styling changes (gatsbyjs#8938)
  fixed typo in migrating-from-v0-to-v1.md (gatsbyjs#8921)
  Add https://developer.bitcoin.com/ to the Site Showcase (gatsbyjs#8931)
  Remove code block (gatsbyjs#8930)
  test(gatsby-plugin-feed): don't snapshot test platform specific (gatsbyjs#8836)
  test: add gatsby-node tests for plugin manifest (gatsbyjs#8598)
  fix(docs): Fix typo in using-gatsby-image.md (gatsbyjs#8889)
  docs: Correcting code diff highlights (gatsbyjs#8913)
  docs: e-commerce tutorial - allow cors request from react fetch (gatsbyjs#8660)
  docs: Updated code diff highlighting (gatsbyjs#8914)
  fix(www): Correct wrong entries in sites + starters (gatsbyjs#8888)
  fix(docs): consistent links to other tutorial parts (gatsbyjs#8860)
  feat(docs): Create "Using Fragments" article (gatsbyjs#8902)
  Use title syntax on markdown code blocks (gatsbyjs#8912)
  chore: use createContentDigest helper (gatsbyjs#8813)
  Updated hyperlink (gatsbyjs#8856)
  [v2/starter] Gatsby v2 Starter based on Bulma (gatsbyjs#8884)
  docs: update Web App Manifest compat (gatsbyjs#8891)
  docs: fix gatsby-source-graphql README links (gatsbyjs#8886)
  docs: fix diff highlighting in StaticQuery example (gatsbyjs#8892)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HM100 HM100 HM100 approved these changes

@pieh pieh pieh approved these changes

@LekoArts LekoArts LekoArts left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomByrer @pieh @LekoArts @HM100