fix(gatsby): replace checks for .cache/json with checks for .cache/caches-lmdb #33431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
This was referenced Oct 5, 2021
vladar
approved these changes
Oct 7, 2021
vladar
removed
the
status: triage needed
|
Looks like npm is down ATM. Will re-run failed tests when it goes up to make sure visual regression one is a fluke and not a real issue (the other two are known to be broken) |
wardpeet
pushed a commit
to herecydev/gatsby
that referenced
this pull request
Oct 29, 2021
axe312ger
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When lmdb-store is used, the cache is kept in
.cache/caches-lmdbinstead of.cache/json. However, even if.cache/jsonis not used in this case, the initialize function checks for the existence of that file and if it doesn't exist then deletes all existing HTML and CSS files.Documentation
Related Issues
Fixes #33262