Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-source-drupal): port hot-fixes for Drupal/Gatsby customer to package #33419

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Oct 4, 2021

Several changes:

  • better logging for fastbuild updates (most useful is it links to URL of changed entity)
  • skip running fastbuilds sync API call if lastFetched isn't set as this call is a) pointless as we know we need to do a full-fetch and b) pretty expensive.
  • only call touchNodes on the first call to sourceNodes as Gatsby (currently) doesn't update that information for subsequent calls so we can save some time there.
  • more tests for relationships updating code

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 4, 2021
@KyleAMathews KyleAMathews added topic: source-drupal Related to Gatsby's integration with Drupal and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 4, 2021
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have enough context on drupal plugin but from my shallow review, this looks good 👍

@vladar vladar merged commit 1777f08 into master Oct 4, 2021
@vladar vladar deleted the psu-drupal-ports branch October 4, 2021 18:58
@cassilup
Copy link

cassilup commented Oct 5, 2021

@vladar, I noticed that you merged this PR with 2 checks failing.
The same checks are failing on #33416 and #33431, for example.
Is there any open issue around fixing these 2 checks?

I'm trying to be of help and this seemed like a first flag along the way. :)

Cc: @raresportan

vladar pushed a commit that referenced this pull request Oct 5, 2021
vladar added a commit that referenced this pull request Oct 5, 2021
… to package (#33419) (#33435)

(cherry picked from commit 1777f08)

Co-authored-by: Kyle Mathews <[email protected]>
Co-authored-by: Vladimir Razuvaev <[email protected]>
@vladar
Copy link
Contributor

vladar commented Oct 5, 2021

@cassilup Yeah, sadly, e2e_tests_contentful and e2e_tests_pnp are currently broken. If you are interested in fixing those - PRs are highly appreciated! You can open an issue first or just submit a PR with a fix but let me know first if you will take it to avoid duplicated work.

e2e_tests_pnp tests are defined here:

gatsby/.circleci/config.yml

Lines 334 to 375 in 22805bd

e2e_tests_pnp:
executor: node
steps:
- checkout
- run: ./scripts/assert-changed-files.sh "packages/*|.circleci/*"
- <<: *attach_to_bootstrap
- run:
command: mkdir -p /tmp/e2e-tests/
working_directory: ~/project
- run:
command: cp -r ./starters/default /tmp/e2e-tests/gatsby-pnp
working_directory: ~/project
- run:
command: touch yarn.lock
working_directory: /tmp/e2e-tests/gatsby-pnp
- run: # Quick upgrade to the v2 (any version, we just need the real set version)
command: yarn policies set-version berry
working_directory: /tmp/e2e-tests/gatsby-pnp
- run: # Explicitly set nodeLinker to avoid Yarn selecting node_modules due to the Yarn 1.x lockfile
command: yarn config set nodeLinker pnp
working_directory: /tmp/e2e-tests/gatsby-pnp
- run: # Allow installs to change the lockfile
command: yarn config set enableImmutableInstalls false
working_directory: /tmp/e2e-tests/gatsby-pnp
- run: # Don't allow any fallback to root dependencies
command: yarn config set pnpFallbackMode none
working_directory: /tmp/e2e-tests/gatsby-pnp
- run: # Forces to use the local packages
command: yarn link --all --private ~/project
working_directory: /tmp/e2e-tests/gatsby-pnp
- run:
command: yarn install
working_directory: /tmp/e2e-tests/gatsby-pnp
- run:
command: yarn add start-server-and-test@^1.11.0
working_directory: /tmp/e2e-tests/gatsby-pnp
- run:
command: yarn build
working_directory: /tmp/e2e-tests/gatsby-pnp
- run:
command: 'DEBUG=start-server-and-test yarn start-server-and-test "yarn develop 2>&1 | tee log.txt" :8000 "! cat log.txt | grep -E ''ERROR #|Require stack:''"'
working_directory: /tmp/e2e-tests/gatsby-pnp
(failing on command: yarn build)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-drupal Related to Gatsby's integration with Drupal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants