Upgrade to Gatsby 3 and fix Heroku caching #2851
Conversation
* update needed dependencies to get gatsby 3 working * add gatsby-plugin-image
|
Weird, this is what site looks like on my end:
Do we need to try rebuilding it? |
|
That was weird, I got it too and a rebuild did indeed fix the fonts for me. The public folder on S3 was malformed, breaking the first build and triggering a full rebuild- not a good portent 😬 I think I remember some similar problems happening on the existing system though. |
|
Everything looks great! Besides a small difference I noticed between dvc.org and the branch, I don't see any issues. This branch's dvc.org blog main image seems to be using |
|
Nice catch! I don't have any preference between the two methods, though I'm a little curious as to why the default was changed from blur to dominant color- maybe lightening the amount of processing needed, or maybe it being deemed as looking better? Either way, we can try setting the default placeholder to blurred to keep parity for now. |
|
Default placeholder is now blur, and I did patch upgrades on some packages. I think this is as good as we're going to get for this PR! With an approval, we can merge and move to the next step of making sure the transition is as seamless as we can make it. |
| { | ||
| resolve: 'gatsby-plugin-sharp', | ||
| options: { | ||
| defaults: { | ||
| placeholder: 'blurred' | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
At some point between our current pinned versions and now, the default placeholder got changed from blur to a "dominant color" strategy. I've changed the default back to blur for parity.
It doesn't seem there's any hit to build time for doing this, my first attempt looked like it but was a false positive.
There was a problem hiding this comment.
Great job on this @rogermparent! We should probably make sure to keep a close eye on dvc.org and sentry errors after we merge this to be safe 😅
Builds off of #2848, adding a script that stabilized build paths to ensure Gatsby doesn't clean its cache when not necessary, among some other changes to help speed up builds as much as we can.
Build times
Old packages (Gatsby 2)
Completely cold cache: 1937s
Automatic cache clear: 612s
Fully warm cache (script backport in #2898): 170s
New packages (Gatsby 4 beta)
Completely cold cache: 840s
Automatic cache clear: 283s
Fully warm cache: 91s