Fix Heroku Caching #2898
Closed
Fix Heroku Caching #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogermparent
had a problem deploying
to
dvc-org-fix-heroku-cach-bhxluv
rogermparent
had a problem deploying
to
dvc-org-fix-heroku-cach-bhxluv
rogermparent
had a problem deploying
to
dvc-org-fix-heroku-cach-bhxluv
rogermparent
had a problem deploying
to
dvc-org-fix-heroku-cach-bhxluv
rogermparent
force-pushed
the
fix-heroku-caching
branch
from
ece8a7f to
d3075e7
Compare
rogermparent
had a problem deploying
to
dvc-org-fix-heroku-cach-bhxluv
rogermparent
had a problem deploying
to
dvc-org-fix-heroku-cach-bhxluv
rogermparent
had a problem deploying
to
dvc-org-fix-heroku-cach-bhxluv
rogermparent
had a problem deploying
to
dvc-org-fix-heroku-cach-bhxluv
rogermparent
force-pushed
the
fix-heroku-caching
branch
from
a2c9a78 to
d3075e7
Compare
julieg18
reviewed
Oct 11, 2021
There was a problem hiding this comment.
Looks great! The only issue I noticed was that the Community/styles.module.css doesn't seem to be converted to regular css correctly:
It looks fine on my iphone safari, but my Windows Brave Browser and Firefox browser show the bug. I wasn't able to test on my Mac since I don't have it with me at the moment.
|
I think you meant to reply on #2851, I got a little confused when I didn't see the issue here but found it when I checked there. Great catch! I'll get on that. |
Yep 😅 |
|
Closing in favor of #2851 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the script from #2851 that fixes Heroku caching by keeping the build path stable. It doesn't include any upgrades to Gatsby and its plugins, since there seems to be a lot of weirdness with
sharpversion mismatches.Even with nothing else, this should speed up caching (after the first run) with very little drawbacks. #2851 is coming as well, but it'll need some babysitting as some existing Gatsby 2 apps break and need their cache turned off to re-add the new one.
It also adds a
retryoption toDEPLOY_OPTIONSthat allows us to disable the "clear-and-retry" attempt which helps with debugging cache issues rapidly.