Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't deploy PSPs when PodSecurityPolicy plugin is disabled #523

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Don't deploy PSPs when PodSecurityPolicy plugin is disabled #523

merged 1 commit into from
Aug 18, 2022

Conversation

shafeeqes
Copy link
Contributor

How to categorize this PR?

/area open-source
/kind enhancement
/platform alicloud

What this PR does / why we need it:
PodSecurityPolicy is deprecated and will be disabled in kubernetes v1.25+.
End-users are provided an option to migrate their PSPs before upgrading and disable the PodSecurityPolicy admission plugin in the ShootSpec.
In that case, we should stop deploying our PSPs as well.

  • This PR stops deploying PSPs related to provider-alicloud if the plugin is disabled in the Shoot.

Which issue(s) this PR fixes:
Part of gardener/gardener#5250

Special notes for your reviewer:
Similar to gardener/gardener-extension-provider-aws#587
/hold Depends on #521

Release note:

Please make sure you're running [email protected] or above before upgrading to this version.

@shafeeqes shafeeqes requested review from a team as code owners August 12, 2022 09:48
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension platform/alicloud Alicloud platform/infrastructure reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Aug 12, 2022
@shafeeqes shafeeqes mentioned this pull request Aug 12, 2022
Closed
23 tasks
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 12, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 12, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 16, 2022
@shaoyongfeng
Copy link
Contributor

Hi @shafeeqes ,
g/g 1.53 is revendored. please rebase your pr

@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Aug 17, 2022
@shafeeqes
Copy link
Contributor Author

Hi @shafeeqes , g/g 1.53 is revendored. please rebase your pr

Done.

@gardener-robot gardener-robot removed the size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) label Aug 17, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 17, 2022
@shafeeqes
Copy link
Contributor Author

/unhold

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Aug 17, 2022
@shaoyongfeng shaoyongfeng merged commit 7f77e02 into gardener:master Aug 18, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaoyongfeng shaoyongfeng shaoyongfeng approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else platform/alicloud Alicloud platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shafeeqes @shaoyongfeng @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot