Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor gardener/[email protected] #521

Merged
merged 8 commits into from
Aug 17, 2022
Merged

Vendor gardener/[email protected] #521

merged 8 commits into from
Aug 17, 2022

Conversation

tedteng
Copy link
Contributor

@tedteng tedteng commented Aug 4, 2022 •
edited
Loading

How to categorize this PR?

/area ops-productivity
/kind enhancement
/platform alicloud

What this PR does / why we need it:
Vendor gardener/[email protected] to be in sync with the other provider extensions for use Bastion config validator feature
https://github.com/gardener/gardener/releases/tag/v1.53.0

Special notes for your reviewer:

Release note:

The following dependency is updated:
- github.com/gardener/gardener: v1.50.1 -> v1.53.0

/invite @dkistner @shafeeqes Thanks

@tedteng tedteng requested review from a team as code owners August 4, 2022 03:11
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension platform/alicloud Alicloud platform/infrastructure needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Aug 4, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 4, 2022
@tedteng tedteng marked this pull request as draft August 4, 2022 03:14
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 5, 2022
@tedteng tedteng marked this pull request as ready for review August 5, 2022 01:06
@tedteng tedteng marked this pull request as draft August 5, 2022 01:09
@gardener-robot
Copy link

@tedteng Command /teset is not known.

@tedteng
Copy link
Contributor Author

tedteng commented Aug 5, 2022

/test

@testmachinery
Copy link

testmachinery bot commented Aug 5, 2022 •
edited
Loading

Testrun: e2e-jtxzv
Workflow: e2e-jtxzv-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 12m39s   |
| bastion-test        | bastion-test        | Succeeded | 8m47s    |
+---------------------+---------------------+-----------+----------+

@tedteng tedteng marked this pull request as ready for review August 5, 2022 01:22
@tedteng tedteng mentioned this pull request Aug 5, 2022
Closed
shafeeqes
shafeeqes reviewed Aug 5, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 5, 2022
@tedteng tedteng force-pushed the vendor/gardener1.52.1 branch from 92ab339 to 80cdbcb Compare August 5, 2022 05:50
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 10, 2022
@tedteng
Copy link
Contributor Author

tedteng commented Aug 10, 2022

/test

@testmachinery
Copy link

testmachinery bot commented Aug 10, 2022 •
edited
Loading

Testrun: e2e-th2hz
Workflow: e2e-th2hz-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 12m31s   |
| bastion-test        | bastion-test        | Succeeded | 9m9s     |
+---------------------+---------------------+-----------+----------+

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 11, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 11, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 12, 2022
@shafeeqes
Copy link
Contributor

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Aug 12, 2022
@shafeeqes shafeeqes mentioned this pull request Aug 12, 2022
Merged
@shafeeqes shafeeqes changed the title Vendor gardener/[email protected] Vendor gardener/[email protected] Aug 12, 2022
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Aug 15, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 15, 2022
@tedteng tedteng changed the title Vendor gardener/[email protected] Vendor gardener/[email protected] Aug 15, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 15, 2022
@shaoyongfeng
Copy link
Contributor

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Aug 17, 2022
@shaoyongfeng shaoyongfeng merged commit b50113d into gardener:master Aug 17, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shafeeqes shafeeqes shafeeqes left review comments

@shaoyongfeng shaoyongfeng shaoyongfeng approved these changes

@dkistner dkistner dkistner left review comments

Assignees
No one assigned
Labels
area/ops-productivity Operator productivity related (how to improve operations) kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/alicloud Alicloud platform/infrastructure reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tedteng @gardener-robot @shafeeqes @shaoyongfeng @dkistner @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3