Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bastion configvalidator #499

Closed
tedteng opened this issue Jun 10, 2022 · 5 comments · Fixed by #527
Closed

Bastion configvalidator #499

tedteng opened this issue Jun 10, 2022 · 5 comments · Fixed by #527
Assignees
Labels
area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension platform/alicloud Alicloud platform/infrastructure status/closed Issue is closed (either delivered or triaged)

Comments

@tedteng
Copy link
Contributor

tedteng commented Jun 10, 2022

How to categorize this issue?

/area ops-productivity
/kind enhancement
/platform alicloud

What would you like to be added:
similar to https://github.com/gardener/gardener/blob/master/docs/extensions/infrastructure.md#configvalidator-interface
after #498, values fetch from InfrastructureStatus implement the validity of cloud provider check, eg varify of vpc resource exists which fetches from the InfrastructureStatus before bastion reconcile.

one example from the issue cluster, vpc not exist from alicloud, but is saved in InfrastructureStatus

spec:
  infrastructureProviderStatus:
    apiVersion: alicloud.provider.extensions.gardener.cloud/v1alpha1
    keyPairName: ""
    kind: InfrastructureStatus
    machineImages:
    - encrypted: true
      id: m-gw8 
      name: gardenlinux
      version: 576.9.0
    vpc:
      id: vpc-gw89xoxxx


aliyun vpc DescribeVpcs --VpcId  vpc-gw89xoxxx
{
	"PageNumber": 1,
	"PageSize": 10,
	"RequestId": "CE96D2C1-24D2-3DD3-9698-E6B66E11DEA3",
	"TotalCount": 0,
	"Vpcs": {
		"Vpc": []
	}
}

Why is this needed:

@gardener-robot gardener-robot added area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension platform/alicloud Alicloud platform/infrastructure labels Jun 10, 2022
@tedteng
Copy link
Contributor Author

tedteng commented Jun 10, 2022

/assign

@tedteng
Copy link
Contributor Author

tedteng commented Aug 5, 2022

/dependence #521 revendor g/g 1.52.1

@gardener-robot
Copy link

@tedteng Command /dependence is not known.

@gardener-robot
Copy link

@tedteng Here my list of commands:

Man Page
Synopsis What & Who Description & Examples
/assign [@user...] Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Commenter
Assign given people (or yourself if none specified) to issue or PR. Commenters may only assign themselves. Labels can be used as well, which are subsituted with the registered reviewers for that label.
Examples:
- /assign
- /assign @johndoe @janedoe
- /assign platform/bare-metal
/unassign [@user...] Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Commenter
Unassign given people (or yourself if none specified) from issue or PR. Commenters may only unassign themselves. Labels can be used as well, which are subsituted with the registered reviewers for that label.
Examples:
- /unassign
- /unassign @johndoe @janedoe
- /unassign platform/bare-metal
/cla Valid for
PullRequest
Permitted for
Anyone
Recheck Contributor License Agreement (CLA) for PR.
Examples:
- /cla
/diag Valid for
Issue
Permitted for
Member,
Author,
Commenter
Run diagnosis on shoot cluster. Can only be invoked with a shoot cluster dashboard link as argument or for shoot cluster issues with a dashboard link in the body and labeled with topology/shoot. Can only be invoked by Gardener staff, shoot cluster project members, or issue authors.
Examples:
- /diag
/duplicate Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author
Mark issue or PR as duplicate of another one. The referenced issue/PR may be in the same repo (e.g. #123 or GH-123), on the same server (e.g. org/repo#123), or even on another server (e.g. https://server/org/repo/issues/123). Author, assignees, and code owners of the referenced issue/PR will be informed about this duplicate. Information will be redacted if this duplicate is private and the referenced one is public. An attempt to reference a private issue/PR from public will be rejected.
Examples:
- /duplicate
/help Valid for
Issue,
PullRequest
Permitted for
Anyone
Get help on all available commands.
Examples:
- /help
Synonyms: /help, /hi, /hello, /hola, /hallo, /rtfm
/add label... Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author
Add label to issue or PR (default if no command is recognized). Authors may only add certain white-listed labels such as kind/*, priority/*, area/*, component/*, os/*, platform/*. The labels can be either fully qualified like kind/bug, just the identifier like bug, or starting with the category like kind followed by one or many identifiers in that category.
Examples:
- /add area/cost component/gardener
- /add cost gardener
- /add kind bug regression
- /area/cost component/gardener
- /cost gardener
- /kind bug regression
Synonyms: /add, /set, /label, /start, /begin
/remove label... Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author
Remove label from issue or PR. Authors may only remove certain white-listed labels such as kind/*, priority/*, area/*, component/*, os/*, platform/*. The labels can be either fully qualified like kind/bug, just the identifier like bug, or starting with the category like kind followed by one or many identifiers in that category.
Examples:
- /remove area/cost component/gardener
- /remove cost gardener
- /remove kind bug regression
Synonyms: /remove, /rem, /unset, /unlabel, /stop, /end, /del, /drop, /cancel
/lgtm Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member
Add reviewed/lgtm label to issue or PR (and remove conflicting labels).
Examples:
- /lgtm
/hold Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author
Add reviewed/do-not-merge label to issue or PR (and remove conflicting labels).
Examples:
- /hold
/unhold Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author
Remove reviewed/do-not-merge label from issue or PR.
Examples:
- /unhold
/close Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author,
Owner
Close issue or PR.
Examples:
- /close
/reopen Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author,
Owner
Reopen issue or PR.
Examples:
- /reopen
Synonyms: /reopen, /open
/touch Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author,
Owner
Remove lifecycle/icebox, stale, or rotten label from issue or PR. Authors may only remove the stale or rotten labels.
Examples:
- /touch
/plan milestone Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member
Set milestone for issue/PR.
Examples:
- /plan 2030-Q1
Synonyms: /plan, /schedule, /milestone
/unplan Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member
Unset milestone for issue.
Examples:
- /unplan
Synonyms: /unplan, /unschedule, /unmilestone
/ping [@user...] [msg] Valid for
Issue,
PullRequest
Permitted for
Anyone
Ping people (or just in general if none specified) with a message to take a look at issue or PR (like /honk in prow). Labels can be used as well, which are subsituted with the registered reviewers for that label.
Examples:
- /ping
- /ping @johndoe @janedoe Have you checked?
- /ping platform/bare-metal Any Progress?
Synonyms: /ping, /honk
/ready-for-review Valid for
PullRequest
Permitted for
Maintainer,
Member,
Author
Turn draft PR into ready for review PR.
Examples:
- /ready-for-review
Synonyms: /ready-for-review, /ready
/invite [@user...] Valid for
PullRequest
Permitted for
Maintainer,
Member,
Author,
Commenter
Request PR review from given people (or yourself if none specified) for PR. Commenters may only invite themselves. Labels can be used as well, which are subsituted with the registered reviewers for that label.
Examples:
- /invite
- /invite @johndoe @janedoe
- /invite platform/bare-metal
Synonyms: /invite, /review
/uninvite [@user...] Valid for
PullRequest
Permitted for
Maintainer,
Member,
Commenter
No longer request PR review from given people (or yourself if none specified) for PR. Commenters may only uninvite themselves. Labels can be used as well, which are subsituted with the registered reviewers for that label.
Examples:
- /uninvite
- /uninvite @johndoe @janedoe
- /uninvite platform/bare-metal
Synonyms: /uninvite, /unreview
/title title Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author
Change title of issue or PR.
Examples:
- /title Add metrics endpoint
Synonyms: /title, /retitle

@gardener-robot
Copy link

@tedteng Command /dependence is not known.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension platform/alicloud Alicloud platform/infrastructure status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants