Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bastion configvalidator #527

Merged
merged 4 commits into from
Sep 5, 2022
Merged

Bastion configvalidator #527

merged 4 commits into from
Sep 5, 2022

Conversation

tedteng
Copy link
Contributor

@tedteng tedteng commented Aug 24, 2022

How to categorize this PR?

/area ops-productivity
/kind enhancement
/platform alicloud

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #499

Special notes for your reviewer:

Release note:

validate bastion config values fetch from InfrastructureStatus

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 24, 2022
@tedteng tedteng force-pushed the bastion-configvalidator branch from 4cc1581 to b037d5b Compare August 24, 2022 06:11
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 24, 2022
@tedteng tedteng marked this pull request as ready for review August 24, 2022 06:28
@tedteng tedteng requested review from a team as code owners August 24, 2022 06:28
@tedteng tedteng marked this pull request as draft August 24, 2022 06:29
@tedteng tedteng marked this pull request as ready for review August 24, 2022 06:42
@tedteng tedteng marked this pull request as draft August 24, 2022 07:40
@tedteng tedteng marked this pull request as ready for review August 24, 2022 07:42
@tedteng tedteng marked this pull request as draft August 24, 2022 08:22
@tedteng tedteng marked this pull request as ready for review August 24, 2022 08:32
@gardener-robot gardener-robot added area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension platform/alicloud Alicloud platform/infrastructure needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Aug 25, 2022
@tedteng tedteng marked this pull request as draft August 25, 2022 06:03
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 25, 2022
@tedteng tedteng marked this pull request as ready for review August 25, 2022 07:53
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 25, 2022
@tedteng tedteng marked this pull request as draft August 25, 2022 09:06
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Aug 26, 2022
@gardener-robot gardener-robot removed the size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) label Aug 31, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 31, 2022
@tedteng tedteng force-pushed the bastion-configvalidator branch from c913a78 to 13316c8 Compare August 31, 2022 06:26
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 31, 2022
@tedteng tedteng force-pushed the bastion-configvalidator branch from 13316c8 to 493aaaa Compare August 31, 2022 06:29
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 31, 2022
@tedteng
testing
0bbf751 
add unit test
@tedteng tedteng force-pushed the bastion-configvalidator branch from 493aaaa to 0bbf751 Compare September 1, 2022 02:31
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 1, 2022
@shaoyongfeng
Copy link
Contributor

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Sep 5, 2022
@shaoyongfeng
Copy link
Contributor

/test

@testmachinery
Copy link

testmachinery bot commented Sep 5, 2022 •
edited
Loading

Testrun: e2e-77wdk
Workflow: e2e-77wdk-wf
Phase: Failed

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 12m30s   |
| bastion-test        | bastion-test        | Failed    | 7m56s    |
+---------------------+---------------------+-----------+----------+

@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else needs/review Needs review and removed reviewed/lgtm Has approval for merging labels Sep 5, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 5, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 5, 2022
@tedteng
Copy link
Contributor Author

tedteng commented Sep 5, 2022

/test

@testmachinery
Copy link

testmachinery bot commented Sep 5, 2022 •
edited
Loading

Testrun: e2e-cjr4q
Workflow: e2e-cjr4q-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 13m11s   |
| bastion-test        | bastion-test        | Succeeded | 10m3s    |
+---------------------+---------------------+-----------+----------+

@shaoyongfeng shaoyongfeng merged commit 8e1ef68 into gardener:master Sep 5, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaoyongfeng shaoyongfeng shaoyongfeng approved these changes

@shafeeqes shafeeqes Awaiting requested review from shafeeqes

Assignees
No one assigned
Labels
area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else platform/alicloud Alicloud platform/infrastructure size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bastion configvalidator
6 participants
@tedteng @gardener-robot @shaoyongfeng @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3