Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't deploy PSPs when PodSecurityPolicy plugin is disabled #587

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented Aug 8, 2022

How to categorize this PR?

/area open-source
/kind enhancement
/platform aws

What this PR does / why we need it:
PodSecurityPolicy is deprecated and will be disabled in kubernetes v1.25+.
End-users are provided an option to migrate their PSPs before upgrading and disable the PodSecurityPolicy admission plugin in the ShootSpec.
In that case, we should stop deploying our PSPs as well.

  • This PR stops deploying PSPs related to provider-aws if the plugin is disabled in the Shoot.

Which issue(s) this PR fixes:
Part of gardener/gardener#5250

Special notes for your reviewer:

Release note:

Please make sure you're running [email protected] or above before upgrading to this version.

@shafeeqes shafeeqes requested review from a team as code owners August 8, 2022 04:07
@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension platform/aws Amazon web services platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 8, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 8, 2022
@shafeeqes
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Aug 8, 2022

Testrun: e2e-m288s
Workflow: e2e-m288s-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| bastion-test        | bastion-test        | Succeeded | 5m15s    |
| dnsrecord-test      | dnsrecord-test      | Succeeded | 6m19s    |
| infrastructure-test | infrastructure-test | Succeeded | 15m53s   |
+---------------------+---------------------+-----------+----------+

@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 8, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 8, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 8, 2022
dkistner
dkistner previously approved these changes Aug 8, 2022
@dkistner
Copy link
Member

dkistner commented Aug 8, 2022

Looks good but some tests need adaption.

@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 8, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 8, 2022
@shafeeqes shafeeqes requested a review from dkistner August 8, 2022 07:25
@shafeeqes
Copy link
Contributor Author

/squash

@gardener-robot gardener-robot added the merge/squash Should be merged via 'Squash and merge' label Aug 8, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 8, 2022
@dkistner
Copy link
Member

dkistner commented Aug 8, 2022

Shall the release note not rather breaking operator as it is only compatible with a g/g @v1.52 or higher?

@shafeeqes
Copy link
Contributor Author

Shall the release note not rather breaking operator as it is only compatible with a g/g @v1.52 or higher?

Corrected. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/aws Amazon web services platform/infrastructure size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants