-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't deploy PSP
s when PodSecurityPolicy
plugin is disabled
#587
Merged
+66
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/open-source
Open Source (community, enablement, contributions, conferences, CNCF, etc.) related
kind/enhancement
Enhancement, improvement, extension
platform/aws
Amazon web services platform/infrastructure
needs/review
Needs review
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
labels
Aug 8, 2022
23 tasks
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 8, 2022
/test |
Testrun: e2e-m288s +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | bastion-test | bastion-test | Succeeded | 5m15s | | dnsrecord-test | dnsrecord-test | Succeeded | 6m19s | | infrastructure-test | infrastructure-test | Succeeded | 15m53s | +---------------------+---------------------+-----------+----------+ |
gardener-robot-ci-1
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 8, 2022
shafeeqes
force-pushed
the
enh/podsecurity
branch
from
August 8, 2022 06:53
1333109
to
8e4e041
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 8, 2022
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 8, 2022
dkistner
previously approved these changes
Aug 8, 2022
Looks good but some tests need adaption. |
gardener-robot
added
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
and removed
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
labels
Aug 8, 2022
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 8, 2022
/squash |
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 8, 2022
Shall the release note not rather |
Corrected. Thanks! |
dkistner
approved these changes
Aug 8, 2022
gardener-robot
added
the
status/closed
Issue is closed (either delivered or triaged)
label
Aug 8, 2022
This was referenced Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/open-source
Open Source (community, enablement, contributions, conferences, CNCF, etc.) related
kind/enhancement
Enhancement, improvement, extension
merge/squash
Should be merged via 'Squash and merge'
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/review
Needs review
platform/aws
Amazon web services platform/infrastructure
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area open-source
/kind enhancement
/platform aws
What this PR does / why we need it:
PodSecurityPolicy
is deprecated and will be disabled in kubernetes v1.25+.End-users are provided an option to migrate their PSPs before upgrading and disable the
PodSecurityPolicy
admission plugin in the ShootSpec.In that case, we should stop deploying our PSPs as well.
provider-aws
if the plugin is disabled in the Shoot.Which issue(s) this PR fixes:
Part of gardener/gardener#5250
Special notes for your reviewer:
Release note: