fix(module-conversion): always include build deps #5671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this account for the fact that build dependencies can be specified as: and I'm assuming that's normalized earlier in the flow but just wanted to confirm. |
thsig
force-pushed
the
module-conversion-build-dependency-fix
branch
from
8f65982 to
8f9a0f9
Compare
Good question—yeah, that's indeed handled by the conversion logic. The build & runtime dependencies are passed through these helpers, respectively: https://github.com/garden-io/garden/blob/main/core/src/resolve-module.ts#L742-L762 |
vvagaytsev
previously approved these changes
Jan 30, 2024
Before this fix, build dependencies weren't being transferred to the generated actions in all cases. This was a problem e.g. if using a `helm` module with a build dependency on a `container` module, whose built image was referenced in the chart (since the missing build dependency meant that the image wasn't necessarily ready by the time the deploy started). This was fixed by simply ensuring that any explicit build dependencies (i.e. under `module.build.dependencies`) are included in the dependencies of any generated runtime actions (Deploys, Tests and Runs). This reflects the 0.12-era semantics, where every test, service and task had a build dependency on the module's build step, which in turn respected any build dependencies declared on the module (under `build.dependencies`).
In the module conversion logic for the `persistentvolumeclaim` type, we don't generate any Build actions (just a single Deploy). This means we shouldn't declare a build dependency for it (since we'd be declaring a dependency on an action that won't exist after the conversion).
Sometimes, it's convenient to see the logger output while debugging test suites. By default, we use the `quiet` logger (which doesn't log anything). Here, we introduce two new env vars for testing, `GARDEN_TESTS_SHOW_LOGS` and `GAREDEN_TESTS_LOG_LEVEL`.
vvagaytsev
force-pushed
the
module-conversion-build-dependency-fix
branch
from
8f9a0f9 to
dddad42
Compare
edvald
reviewed
Jan 30, 2024
edvald
approved these changes
Jan 30, 2024
thsig
added a commit
that referenced
this pull request
Jan 30, 2024
This is a follow-up to #5671 (see `47c24d5`). We also need to remove the added dependencies on the build steps of `persistentvolumeclaim` modules, since the converted actions there don't include a Build action. Although this hasn't been reported yet, this would result in missing dependency errors when executing Runs or Tests that come from `container` modules which mount a `persistentvolumeclaim` module (using the `volumes` config field for `container` module services).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
* fix(module-conversion): more fixes to PVC type This is a follow-up to #5671 (see `47c24d5`). We also need to remove the added dependencies on the build steps of `persistentvolumeclaim` modules, since the converted actions there don't include a Build action. Although this hasn't been reported yet, this would result in missing dependency errors when executing Runs or Tests that come from `container` modules which mount a `persistentvolumeclaim` module (using the `volumes` config field for `container` module services). * test: fix tests --------- Co-authored-by: Vladimir Vagaytsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this fix, build dependencies weren't being transferred to the generated actions in all cases.
This was a problem e.g. if using a
helmmodule with a build dependency on acontainermodule, whose built image was referenced in the chart (since the missing build dependency meant that the image wasn't necessarily ready by the time the deploy started).This was fixed by simply ensuring that any explicit build dependencies (i.e. under
module.build.dependencies) are included in the dependencies of any generated runtime actions (Deploys, Tests and Runs).This reflects the 0.12-era semantics, where every test, service and task had a build dependency on the module's build step, which in turn respected any build dependencies declared on the module (under
build.dependencies).Which issue(s) this PR fixes:
Fixes #5667