fix(module-conversion): more fixes to PVC type #5681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to #5671 (see `47c24d5`). We also need to remove the added dependencies on the build steps of `persistentvolumeclaim` modules, since the converted actions there don't include a Build action. Although this hasn't been reported yet, this would result in missing dependency errors when executing Runs or Tests that come from `container` modules which mount a `persistentvolumeclaim` module (using the `volumes` config field for `container` module services).
vvagaytsev
approved these changes
Jan 30, 2024
vvagaytsev
deleted the
module-conversion-build-dependency-fix-continued
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a follow-up to #5671 (see
47c24d5). We also need to remove the added dependencies on the build steps ofpersistentvolumeclaimmodules, since the converted actions there don't include a Build action.Although this hasn't been reported yet, this would result in missing dependency errors when executing Runs or Tests that come from
containermodules which mount apersistentvolumeclaimmodule (using thevolumesconfig field forcontainermodule services).