Skip to content

Commit

Permalink
fix(module-conversion): more fixes to PVC type
Browse files Browse the repository at this point in the history
This is a follow-up to #5671 (see `47c24d5`). We also need to remove the
added dependencies on the build steps of `persistentvolumeclaim`
modules, since the converted actions there don't include a Build action.

Although this hasn't been reported yet, this would result in missing
dependency errors when executing Runs or Tests that come from
`container` modules which mount a `persistentvolumeclaim` module (using
the `volumes` config field for `container` module services).
  • Loading branch information
thsig committed Jan 30, 2024
1 parent 47c24d5 commit 94f730c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions core/src/plugins/container/container.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ export async function configureContainerModule({ log, moduleConfig }: ConfigureM
moduleConfig.testConfigs = moduleConfig.spec.tests.map((t) => {
for (const volume of t.volumes) {
if (volume.module) {
moduleConfig.build.dependencies.push({ name: volume.module, copy: [] })
t.dependencies.push(volume.module)
}
}
Expand All @@ -125,7 +124,6 @@ export async function configureContainerModule({ log, moduleConfig }: ConfigureM
moduleConfig.taskConfigs = moduleConfig.spec.tasks.map((t) => {
for (const volume of t.volumes) {
if (volume.module) {
moduleConfig.build.dependencies.push({ name: volume.module, copy: [] })
t.dependencies.push(volume.module)
}
}
Expand Down

0 comments on commit 94f730c

Please sign in to comment.