Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(k8s): local mode for kubernetes modules #3003

Merged
merged 16 commits into from
Jul 4, 2022
Merged

feat(k8s): local mode for kubernetes modules #3003

merged 16 commits into from
Jul 4, 2022

Conversation

vvagaytsev
Copy link
Collaborator

@vvagaytsev vvagaytsev commented Jun 13, 2022 •
edited
Loading

What this PR does / why we need it:
Local mode for kubernetes modules. This is based on the changes made in #2949.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@vvagaytsev vvagaytsev changed the base branch from master to feat/local-mode-with-reverse-k8s-proxy June 13, 2022 13:29
@vvagaytsev vvagaytsev changed the title feat: local mode k8s module feat: local mode for kubernetes and helm modules Jun 13, 2022
@vvagaytsev vvagaytsev force-pushed the feat/local-mode-k8s-module branch 4 times, most recently from bd136d0 to ba38738 Compare June 14, 2022 15:54
@vvagaytsev vvagaytsev force-pushed the feat/local-mode-with-reverse-k8s-proxy branch from 595bedf to fb6b9f5 Compare June 15, 2022 07:57
@vvagaytsev vvagaytsev force-pushed the feat/local-mode-k8s-module branch from ba38738 to a84c236 Compare June 16, 2022 10:47
@vvagaytsev vvagaytsev force-pushed the feat/local-mode-with-reverse-k8s-proxy branch from fb6b9f5 to 6c495a0 Compare June 16, 2022 12:51
@vvagaytsev vvagaytsev force-pushed the feat/local-mode-k8s-module branch 2 times, most recently from 0c441e2 to 0c01aa2 Compare June 17, 2022 09:50
@vvagaytsev vvagaytsev force-pushed the feat/local-mode-with-reverse-k8s-proxy branch from 8a28d70 to 007b934 Compare June 20, 2022 08:43
@vvagaytsev vvagaytsev force-pushed the feat/local-mode-k8s-module branch from 0c01aa2 to 49f61be Compare June 20, 2022 11:28
@vvagaytsev vvagaytsev force-pushed the feat/local-mode-with-reverse-k8s-proxy branch 2 times, most recently from 18e3e4f to ead89ba Compare June 21, 2022 09:26
@vvagaytsev vvagaytsev force-pushed the feat/local-mode-k8s-module branch from 49f61be to 31bc03e Compare June 21, 2022 09:49
@vvagaytsev vvagaytsev force-pushed the feat/local-mode-with-reverse-k8s-proxy branch 2 times, most recently from 354ba38 to 98dbe28 Compare June 21, 2022 12:29
Base automatically changed from feat/local-mode-with-reverse-k8s-proxy to master June 21, 2022 12:52
@vvagaytsev vvagaytsev force-pushed the feat/local-mode-k8s-module branch 11 times, most recently from ac2b10f to c234ee2 Compare June 27, 2022 15:21
vvagaytsev added 11 commits July 1, 2022 13:38
@vvagaytsev
fix: os commands rendering in log messages
2bd780a
@vvagaytsev
feat: configure local mode in kubernetes manifests
9e43fbc 
[Experimental] Create kubectl port-forward to a taregt Workload
instead of a Service.

This is more unified approach.
This allows to re-use the same machinery
for containers, helm and kubernetes modules.
@vvagaytsev
refactor: extracted aux function and simplified result creation
d008cec
@vvagaytsev
feat(k8s): local mode for kubernetes modules
0a00094
@vvagaytsev
fix: remove original container args to avoid startup failures
9b9d315
@vvagaytsev
docs: updated config description of kubernetes module
0d07c58
@vvagaytsev
chore(examples): local mode example for kubernetes module type
0b9349e
@vvagaytsev
docs(k8s): updated main local mode guide and fixed some links
1ebef2a
@vvagaytsev
chore(examples): updated readme guide for container local mode example
698f082
@vvagaytsev
docs(examples): described the expected results in example docs
ae16f7b
@vvagaytsev
improvement: removed some repetitive log messages
3163961
@vvagaytsev vvagaytsev force-pushed the feat/local-mode-k8s-module branch from 8d5ec5e to 3163961 Compare July 1, 2022 12:02
@vvagaytsev
Copy link
Collaborator Author

@wojciechka the local mode for kubernetes modules has been implemented in this PR. We're planning to merge it next week. Feel free to test the latest build of the branch. Any feedback and comments are highly appreciated!

@vvagaytsev vvagaytsev changed the title feat: local mode for kubernetes module feat(k8s): local mode for kubernetes modules Jul 1, 2022
Orzelius
Orzelius reviewed Jul 4, 2022
View reviewed changes
core/src/plugins/kubernetes/config.ts Outdated Show resolved Hide resolved
core/src/plugins/kubernetes/config.ts Outdated Show resolved Hide resolved
examples/local-mode-k8s/backend-local/main.go Outdated Show resolved Hide resolved
examples/local-mode-k8s/backend/garden.yml Show resolved Hide resolved
thsig
thsig requested changes Jul 4, 2022
View reviewed changes
Copy link
Collaborator

@thsig thsig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I've only got text-related comments on this one.

core/src/plugins/kubernetes/helm/config.ts Show resolved Hide resolved
core/src/plugins/kubernetes/kubernetes-module/handlers.ts Outdated Show resolved Hide resolved
core/src/plugins/kubernetes/kubernetes-module/handlers.ts Show resolved Hide resolved
core/src/plugins/kubernetes/kubernetes-module/handlers.ts Outdated Show resolved Hide resolved
core/src/plugins/kubernetes/container/deployment.ts Outdated Show resolved Hide resolved
core/src/plugins/kubernetes/config.ts Outdated Show resolved Hide resolved
docs/guides/running-service-in-local-mode.md Outdated Show resolved Hide resolved
docs/guides/running-service-in-local-mode.md Outdated Show resolved Hide resolved
docs/guides/running-service-in-local-mode.md Show resolved Hide resolved
docs/guides/running-service-in-local-mode.md Outdated Show resolved Hide resolved
@vvagaytsev vvagaytsev requested review from Orzelius and thsig July 4, 2022 11:44
@thsig
Copy link
Collaborator

thsig commented Jul 4, 2022

Looks good to me—unless @Orzelius has any further comments, I think we're good to merge.

Orzelius
Orzelius approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@Orzelius Orzelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@10ko
Copy link
Member

10ko commented Jul 4, 2022

🚀

@vvagaytsev vvagaytsev merged commit f44ff39 into master Jul 4, 2022
@vvagaytsev vvagaytsev deleted the feat/local-mode-k8s-module branch July 4, 2022 14:01
@wojciechka
Copy link

@wojciechka the local mode for kubernetes modules has been implemented in this PR. We're planning to merge it next week. Feel free to test the latest build of the branch. Any feedback and comments are highly appreciated!

@vvagaytsev I apologize for the delay, I will check it later this week or early next week.

I'm currently out of office and may not have a lot of time, but I'll do my best to check it as soon as I can, as I am very curious about this PR and how it works.

@vvagaytsev vvagaytsev mentioned this pull request Jul 5, 2022
Merged
@wojciechka
Copy link

@wojciechka the local mode for kubernetes modules has been implemented in this PR. We're planning to merge it next week. Feel free to test the latest build of the branch. Any feedback and comments are highly appreciated!

Hi! I've tested the solution and it works as expected in my initial tests.

I'll work on trying to integrate it in our tooling and see if I can get it working end to end in our tooling. I couldn't easily do that with container module but should be doable now.

One question, though - is there a way to have local command write to stdout or where would the logs from the command be?

Seeing stdout/stderr in real time would be useful for our engineers.

@vvagaytsev
Copy link
Collaborator Author

Thanks for the feedback @wojciechka! Now the local application's logs are only printed in the .garden/deploy.debug.*.log files. But I've created #3050 to print the local app's stdout in real-time on the verbose log level.

We'll include that PR in the next Core release which is planned to be done this week.

The next release will also have local mode support in helm modules, that was done in #3033.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orzelius Orzelius Orzelius approved these changes

@thsig thsig thsig approved these changes

@edvald edvald Awaiting requested review from edvald

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vvagaytsev @thsig @10ko @wojciechka @Orzelius