improvement: removed some repetitive log messages

garden-io · Jul 1, 2022 · 3163961 · 3163961
1 parent ae16f7b
commit 3163961
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/core/src/plugins/kubernetes/container/deployment.ts b/core/src/plugins/kubernetes/container/deployment.ts
@@ -136,11 +136,6 @@ export async function startLocalMode({
     return
   }
 
-  log.warn({
-    section: service.name,
-    msg: chalk.grey(`Starting in local mode`),
-  })
-
   const namespace = await getAppNamespace(ctx, log, ctx.provider)
   const targetResource = status.detail.remoteResources.find((r) =>
     hotReloadableKinds.includes(r.kind)

diff --git a/core/src/plugins/kubernetes/local-mode.ts b/core/src/plugins/kubernetes/local-mode.ts
@@ -537,6 +537,8 @@ async function getKubectlPortForwardProcess(
   )
   const { ctx, gardenService, log } = configParams
 
+  let lastSeenSuccessMessage = ""
+
   return new RecoverableProcess({
     osCommand: kubectlPortForwardCmd,
     retryConfig: {
@@ -573,12 +575,18 @@ async function getKubectlPortForwardProcess(
       hasErrors: (_chunk: any) => false,
       onError: (_msg: ProcessMessage) => {},
       onMessage: (msg: ProcessMessage) => {
+        const consoleMessage = composeMessage("Kubectl SSH port-forward is up and running", msg)
+        if (consoleMessage === lastSeenSuccessMessage) {
+          return
+        }
+
         if (msg.message.includes("Handling connection for")) {
           log.info({
             status: "success",
             section: gardenService.name,
-            msg: chalk.white(composeMessage("Kubectl SSH port-forward is up and running", msg)),
+            msg: chalk.white(consoleMessage),
           })
+          lastSeenSuccessMessage = consoleMessage
         }
       },
     },