Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(k8s): verbose logging of the local app output in local mode #3050

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

vvagaytsev
Copy link
Collaborator

What this PR does / why we need it:
This PR allows to watch the local app's logs in realtime when running local-mode with verbose log level:

garden deploy --local -l 3

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@vvagaytsev vvagaytsev requested review from Orzelius and thsig July 12, 2022 12:47
@vvagaytsev vvagaytsev force-pushed the improvement/local-mode-app-stdout-verbose-logging branch 5 times, most recently from 1b1f50a to 65d42ed Compare July 12, 2022 16:19
Copy link
Contributor

@Orzelius Orzelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry this took so long but the review is finally here. Ping me to give the final approve when you need it

core/src/plugins/kubernetes/local-mode.ts Show resolved Hide resolved
docs/guides/running-service-in-local-mode.md Outdated Show resolved Hide resolved
@vvagaytsev vvagaytsev requested a review from Orzelius July 13, 2022 10:32
@vvagaytsev vvagaytsev force-pushed the improvement/local-mode-app-stdout-verbose-logging branch from 1afc996 to 3419cb6 Compare July 13, 2022 10:48
@vvagaytsev vvagaytsev merged commit 6450936 into master Jul 13, 2022
@vvagaytsev vvagaytsev deleted the improvement/local-mode-app-stdout-verbose-logging branch July 13, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants