-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chewbbaca update #6000
Chewbbaca update #6000
Conversation
tools/chewbbaca/AlleleCall.xml
Outdated
@@ -8,7 +8,7 @@ | |||
mkdir 'input' && | |||
mkdir 'schema' && | |||
#for $file in $input_file | |||
ln -sf '$file' 'input/${file.element_identifier}' && | |||
ln -sf '$file' 'input/${file.element_identifier}.fa' && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the element identifier here? Or can we just name it input/foo.fa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AlleleCall accepts multiple input FASTAs. I think in that case it overwrites the inputs. Am I right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use foo_1 foo_2 please search in this repo for enumerate ... We do that often
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, thats bad. Ok lets keep the element_identifier then, but please sanatize them as here for example:
tools-iuc/tools/picard/picard_macros.xml
Line 33 in 1056d5c
#set escaped_element_identifier = re.sub('[^\w\-]', '_', str($inputFile.element_identifier)) |
FOR CONTRIBUTOR:
This update resolves two issues: