Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snapatac2 wrappers #5740

Merged
merged 34 commits into from
May 16, 2024
Merged

Add Snapatac2 wrappers #5740

merged 34 commits into from
May 16, 2024

Conversation

y4nnick8
Copy link
Contributor

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@y4nnick8 y4nnick8 marked this pull request as draft January 29, 2024 12:35
@bgruening
Copy link
Member

.shed.yml file is missing

@pavanvidem
Copy link
Member

For datasets with larger than 1MB, I used location attribute with Zenodo links. All those tests resulted in the error message: Input staging problem: Timed out after 1800.25 seconds waiting on tool test run. The Zenodo links are public and accessible. With my local planemo test also I could see the data was fetched into the jwd.

@bgruening bgruening marked this pull request as ready for review May 14, 2024 19:47
@bgruening bgruening closed this May 14, 2024
@bgruening bgruening reopened this May 14, 2024
@pavanvidem
Copy link
Member

I'm using 23.0 profile in the macros. Is it fine or better to go down to 22.05?

@bgruening
Copy link
Member

I guess its fine, we need to have an IUC rule here at some point.

@@ -0,0 +1,586 @@
<tool id="snapatac2_clustering" name="SnapATAC2 Clustering" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<tool id="snapatac2_clustering" name="SnapATAC2 Clustering" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@">
<tool id="snapatac2_clustering" name="SnapATAC2 Clustering" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@" profile="22.05">

@bgruening bgruening merged commit be132b5 into galaxyproject:main May 16, 2024
13 checks passed
@pavanvidem
Copy link
Member

Thanks a lot @bgruening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants