-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miniprot Update version v0.10 to v0.12 #5317
Miniprot Update version v0.10 to v0.12 #5317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thanks! Looks very good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test covering the --trans
parameter?
Co-authored-by: Anthony Bretaudeau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that the --trans
adds a comment line (which is an important detail) ## STA\t...
followed by the translation.
There seem to be an additional line containing "tr|I6YGH7|I6YGH7_MYCTU"
.. which seems incompatible with the gtf definition... is this desired (and is this due to --trans
?)
I did a test on each output format of the new feature. I also put in the test-data folder, an example of output with the --trans parameter |
I've added a comment in the script to warn of the bug while waiting for the new realease. |
@rlibouba do you expect a release in the next days? Would we maybe hide the --trans parameter to not get user questions about this bug? |
No, I don't have any information about the fix. I check regularly. |
Hiding the option (i.e. commenting) would be fine for me .. up to you. |
It's ok for me to hide it |
Thank you for your feedback. I've hidden the parameter until the bug is fixed. |
A new version is now available. As soon as the conda package is up to date, I'll add the new features added by this update |
Cool very nice @rlibouba! @bernt-matthias ready from your side? |
Thanks a lot @rlibouba! |
FOR CONTRIBUTOR: