Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miniprot Update version v0.10 to v0.12 #5317

Merged
merged 16 commits into from
Jul 13, 2023

Conversation

rlibouba
Copy link
Contributor

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@rlibouba rlibouba marked this pull request as draft May 22, 2023 11:52
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks! Looks very good!

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test covering the --trans parameter?

@rlibouba rlibouba marked this pull request as ready for review May 23, 2023 10:00
Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that the --trans adds a comment line (which is an important detail) ## STA\t... followed by the translation.

There seem to be an additional line containing "tr|I6YGH7|I6YGH7_MYCTU" .. which seems incompatible with the gtf definition... is this desired (and is this due to --trans?)

tools/miniprot/miniprot.xml Outdated Show resolved Hide resolved
@rlibouba
Copy link
Contributor Author

I did a test on each output format of the new feature. I also put in the test-data folder, an example of output with the --trans parameter

@rlibouba
Copy link
Contributor Author

I've added a comment in the script to warn of the bug while waiting for the new realease.

@bgruening
Copy link
Member

@rlibouba do you expect a release in the next days? Would we maybe hide the --trans parameter to not get user questions about this bug?

@rlibouba
Copy link
Contributor Author

No, I don't have any information about the fix. I check regularly.
We can hide it in the meantime. What do you think @bernt-matthias and @abretaud ?

@bernt-matthias
Copy link
Contributor

Hiding the option (i.e. commenting) would be fine for me .. up to you.

@abretaud
Copy link
Contributor

It's ok for me to hide it

@rlibouba
Copy link
Contributor Author

Thank you for your feedback. I've hidden the parameter until the bug is fixed.

tools/miniprot/miniprot.xml Show resolved Hide resolved
tools/miniprot/miniprot.xml Show resolved Hide resolved
tools/miniprot/miniprot.xml Outdated Show resolved Hide resolved
@rlibouba
Copy link
Contributor Author

A new version is now available. As soon as the conda package is up to date, I'll add the new features added by this update

@rlibouba rlibouba changed the title Miniprot Update version v0.10 to v0.11 Miniprot Update version v0.10 to v0.12 Jun 30, 2023
@bgruening
Copy link
Member

Cool very nice @rlibouba!

@bernt-matthias ready from your side?

@bernt-matthias bernt-matthias merged commit 7686c03 into galaxyproject:main Jul 13, 2023
@bernt-matthias
Copy link
Contributor

Thanks a lot @rlibouba!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants