Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bowtie overcommits CPU ressources #5983

Closed
bernt-matthias opened this issue May 2, 2024 · 0 comments · Fixed by #5985
Closed

Bowtie overcommits CPU ressources #5983

bernt-matthias opened this issue May 2, 2024 · 0 comments · Fixed by #5985

Comments

@bernt-matthias
Copy link
Contributor

bowtie seems to be extremely efficient, i.e. X GALAXY_SLOTS are used the CPU usage is most of the time larger than X*100% (if checked in top). This seems to be because the -p parameter seems to control the number of (additional) alignment threads (probably plus 1 control thread).

Additionally we pipe the result to samtools using potentially GALAXY_SLOTS more slots (in practice most of the time less).

In summary I would suggest to remove the pipes (to the cost of having an additional temporary file.)

bernt-matthias added a commit to bernt-matthias/tools-iuc that referenced this issue May 3, 2024
fixes galaxyproject#5983

by using a pipe bowtie2 and samtools run in parallel. since already
bowtie2 alone uses more CPU than the assigned ones (less that 1 core)
we should not do this, but run them serially.

also properly redirects stderr.
bernt-matthias added a commit that referenced this issue May 13, 2024
* bowtie2: do not use pipes

fixes #5983

by using a pipe bowtie2 and samtools run in parallel. since already
bowtie2 alone uses more CPU than the assigned ones (less that 1 core)
we should not do this, but run them serially.

also properly redirects stderr.

* fix linting

* remove --no-PG

* restore piping

* reduce number of used threads by one

* Revert "fix linting"

This reverts commit 6e1b4f2.

* bump

* Improve comment wording

Co-authored-by: Wolfgang Maier <[email protected]>

---------

Co-authored-by: Wolfgang Maier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant