-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated version of pretext workflow developed by Delphine that takes HiFi and HiC as input. #584
base: main
Are you sure you want to change the base?
Conversation
…takes HiFi and HiC as input.
Nice! Can you take a look at https://github.com/galaxyproject/iwc/blob/main/workflows/README.md#adding-workflows ? |
Thanks! I will read through the readme and update the workflow. |
... and modify the replacement expressions so that users don't have to add the &. to the suffixes
… go around the fasta implicit conversion problem
Need to solve galaxyproject/galaxy#19143 as soon as possible to settle on a way to deal with compressed haplotypes inputs |
I am not sure why the tests are not running. Could someone take a look ? |
workflows/VGP-assembly-v2/Pre-Curation_PretextMap/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
HiC reads - forward: | ||
class: Collection | ||
collection_type: list | ||
elements: | ||
- class: File | ||
identifier: HiC forward reads | ||
location: https://zenodo.org/records/14218240/files/Hi-C%20forward%20reads.fastqsanger.gz | ||
HiC reads - reverse: | ||
class: Collection | ||
collection_type: list | ||
elements: | ||
- class: File | ||
identifier: HI-C reverse reads | ||
location: https://zenodo.org/records/14218240/files/HI-C%20reverse%20reads.fastqsanger.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not a paired collection ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we are aligning the two separately as single reads to the reference. If we use a paired collection BWA-MEM2 will align them as paired reads with an expected distance between the pairs and that won't work for Hi-C
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you basing this pipeline on something existing ? Otherwise -SP
would disable pairing and mate rescue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's based on the pipeline they have been using for the VGP. It does the same separate alignment in scaffolding workflow, and it has a specific tool for merging alignments for Arima Hi-C reads. Also the workflow 4, assembly with HiC, needs them to be in 2 separate collections, so it may be easier for the user to use the same collections throughout the whole process. We can discuss using the -SP option for a future release, we'd need to test is works the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I would bring that up. What tool is this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workflows/VGP-assembly-v2/Pre-Curation_PretextMap/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-Curation_PretextMap/PretextMap_Generation-tests.yml
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-Curation_PretextMap/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-Curation_PretextMap/.dockstore.yml
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/PretextMap_Generation-tests.yml
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/PretextMap_Generation-tests.yml
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/README.md
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/PretextMap_Generation.ga
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/README.md
Outdated
Show resolved
Hide resolved
workflows/VGP-assembly-v2/Pre-curation-Hi-C-map-generation/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can merge this, but I'd urge you to think of better folder and workflow names. if you look at https://github.com/orgs/iwc-workflows/repositories?type=all most folders/repos are all-lowercase, I think that looks much nicer once we publish that to https://iwc.galaxyproject.org/.
Test Results (powered by Planemo)Test Summary
|
updated version of pretext workflow developed by Delphine that takes HiFi and HiC as input.