Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge latest 24.2 into dev. #19302

Closed
wants to merge 45 commits into from
Closed

Conversation

jmchilton
Copy link
Member

Clean merge, will click the button after the tests.

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

nsoranzo and others added 30 commits November 22, 2024 12:16
Also:
- Update title of reopened PRs too.
- Don't unnecessarily checkout the repo.
…ck_base_ref_changed

[24.0] Update title of edited PRs only if base ref changed
if the step is not a job step. This broke in galaxyproject@ab2f76c
where
```
                # Safeguard: imported_invocation_step was implicitly merged into this Session prior to SQLAlchemy 2.0.
                self.sa_session.add(imported_invocation_step)
```
was replaced with
```
ensure_object_added_to_session(imported_invocation, session=self.sa_session)
```
which seems like a small typo-like bug.
Without this change jobs like `__EXTRACT_DATASET__` would not be
included in a history or invocation export`.
It's a temporary path and probably doesn't make much sense in the
context of an imported invocation.
…hange-base

[24.0] Update PR title handling for changing base ref
…invocation_export_issues

[24.0] Fix various invocation export issues
[24.0] Create harmonized collections from correct tool outputs
and use force prop in `WorkflowNavigationTitle`
This shows a href route for the button in the browser, and keeping an empty `@click` event means we keep the button styling.
Also, account for `deleting` state in `useInvocationGraph` when getting the state for a graph step.
Test STS link generation of RO crates and native model store format.
jmchilton and others added 15 commits December 9, 2024 13:00
The "chart" class was braking Vega's CSS
Slightly increase for improved visibility
Make it dynamic like the other one for time.
…low_metrics_chart_style

[24.2] Fix workflow metrics chart style
[24.1] flip default value for use_mamba to false
…_merge

[24.1] Fix bad merge conflict resolution
…ling_invocation

[24.2] Fix cancellation of workflow scheduling
[24.2] Release testing - selenium tests for workflow invocation export.
@nsoranzo
Copy link
Member

Ops, I just merged forward all the way from release_24.0 to dev before seeing this, close?

@jmchilton jmchilton closed this Dec 10, 2024
@jmchilton
Copy link
Member Author

Not a problem - I am just glad it done. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.