-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge latest 24.2 into dev. #19302
Closed
Closed
Merge latest 24.2 into dev. #19302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Update title of reopened PRs too. - Don't unnecessarily checkout the repo.
…ck_base_ref_changed [24.0] Update title of edited PRs only if base ref changed
…tle formatting more efficiently
…accuracy Co-authored-by: Nicola Soranzo <[email protected]>
if the step is not a job step. This broke in galaxyproject@ab2f76c where ``` # Safeguard: imported_invocation_step was implicitly merged into this Session prior to SQLAlchemy 2.0. self.sa_session.add(imported_invocation_step) ``` was replaced with ``` ensure_object_added_to_session(imported_invocation, session=self.sa_session) ``` which seems like a small typo-like bug.
Without this change jobs like `__EXTRACT_DATASET__` would not be included in a history or invocation export`.
…f hdca points to self
It's a temporary path and probably doesn't make much sense in the context of an imported invocation.
…hange-base [24.0] Update PR title handling for changing base ref
…invocation_export_issues [24.0] Fix various invocation export issues
[24.0] Create harmonized collections from correct tool outputs
and use force prop in `WorkflowNavigationTitle`
This shows a href route for the button in the browser, and keeping an empty `@click` event means we keep the button styling.
Also, account for `deleting` state in `useInvocationGraph` when getting the state for a graph step.
Test STS link generation of RO crates and native model store format.
Co-authored-by: David López <[email protected]>
Co-authored-by: Marius van den Beek <[email protected]>
[24.2] Fix workflow change stack broken with galaxyproject#19230
The "chart" class was braking Vega's CSS
Slightly increase for improved visibility
Make it dynamic like the other one for time.
…low_metrics_chart_style [24.2] Fix workflow metrics chart style
[24.1] flip default value for use_mamba to false
…_merge [24.1] Fix bad merge conflict resolution
…ling_invocation [24.2] Fix cancellation of workflow scheduling
[24.2] Release testing - selenium tests for workflow invocation export.
github-actions
bot
added
area/UI-UX
area/testing
area/database
Galaxy's database or data access layer
area/tool-framework
area/tool-dependencies
area/testing/integration
area/testing/selenium
labels
Dec 10, 2024
Ops, I just merged forward all the way from release_24.0 to dev before seeing this, close? |
Not a problem - I am just glad it done. Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/database
Galaxy's database or data access layer
area/testing/integration
area/testing/selenium
area/testing
area/tool-dependencies
area/tool-framework
area/UI-UX
kind/bug
kind/enhancement
merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean merge, will click the button after the tests.
How to test the changes?
(Select all options that apply)
License