Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.2] Fix cancellation of workflow scheduling #19238

Merged
merged 7 commits into from
Dec 10, 2024
Merged

[24.2] Fix cancellation of workflow scheduling #19238

merged 7 commits into from
Dec 10, 2024

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Dec 3, 2024 •
edited
Loading

Fixes #19237

Also:

  • Fixes force router push in WorkflowRunButton
  • Consolidates styling of WorkflowNavigationTitle with the tool form header styling

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 25.0 milestone Dec 3, 2024
@ahmedhamidawan ahmedhamidawan modified the milestones: 25.0, 24.2 Dec 3, 2024
@ahmedhamidawan
fix force routing for WorkflowRunButton
274da12 
and use force prop in `WorkflowNavigationTitle`
@ahmedhamidawan
use to prop for edit button in WorkflowNavigationTitle
1415920 
This shows a href route for the button in the browser, and keeping an empty `@click` event means we keep the button styling.
@ahmedhamidawan
match WorkflowNavigationTitle styling with ToolCard header
24ba9c2
@ahmedhamidawan
fix jest to align with the workflow nav header changes
98236e1
@ahmedhamidawan
poll if invocation state is not terminal again
69ae867 
Also, account for `deleting` state in `useInvocationGraph` when getting the state for a graph step.
@ahmedhamidawan
adjust ProgressBar props to fix console errors
53c8fb5
@mvdbeek mvdbeek merged commit 6a22083 into galaxyproject:release_24.2 Dec 10, 2024
27 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Dec 10, 2024

Thank you!

@ahmedhamidawan ahmedhamidawan linked an issue Dec 10, 2024 that may be closed by this pull request
[24.2] Cannot cancel workflow when it is running #19237
Closed
@ahmedhamidawan ahmedhamidawan mentioned this pull request Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek left review comments

Assignees
No one assigned
Labels
area/UI-UX area/workflows kind/bug
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.

[24.2] Cannot cancel workflow when it is running
2 participants
@ahmedhamidawan @mvdbeek