[24.2] Fix usability of workflow best practice attribute checking. #19230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have these links that just bring up the attributes page without any added context about which parameter you clicked or why you want to edit it. I think this is jarring and a usability bug (I'd like to backport this to 24.2 after the activity bar stuff is merged).
With these changes it now highlights the attribute you clicked the link for and displays the same message about why it is important from the best practice panel as a popover:
I'd love to allow the editing of these things inline also (#10989) but I think that guiding users to the correct place to edit these things and explaining why in context has its own value.
How to test the changes?
(Select all options that apply)
License