Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Fix usability of workflow best practice attribute checking. #19230

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

jmchilton
Copy link
Member

@jmchilton jmchilton commented Dec 2, 2024

We have these links that just bring up the attributes page without any added context about which parameter you clicked or why you want to edit it. I think this is jarring and a usability bug (I'd like to backport this to 24.2 after the activity bar stuff is merged).

Screenshot 2024-12-02 at 10 13 54 AM

With these changes it now highlights the attribute you clicked the link for and displays the same message about why it is important from the best practice panel as a popover:

Screenshot 2024-12-02 at 10 14 01 AM

I'd love to allow the editing of these things inline also (#10989) but I think that guiding users to the correct place to edit these things and explaining why in context has its own value.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Create a workflow without an annotation or creator or license and open the best practice panel and click the respective links. Notice the new popover and highlight.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton added kind/bug kind/enhancement area/workflows release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them labels Dec 2, 2024
@jmchilton jmchilton changed the base branch from dev to release_24.2 December 5, 2024 14:58
@jmchilton jmchilton changed the title Fix usability of workflow best practice attribute checking. [24.2] Fix usability of workflow best practice attribute checking. Dec 5, 2024
@jmchilton jmchilton marked this pull request as ready for review December 5, 2024 20:46
@github-actions github-actions bot added this to the 25.0 milestone Dec 5, 2024
@bgruening bgruening modified the milestones: 25.0, 24.2 Dec 8, 2024
@bgruening bgruening merged commit 58c22dc into galaxyproject:release_24.2 Dec 8, 2024
30 checks passed
@bgruening
Copy link
Member

Thanks @jmchilton

jmchilton added a commit that referenced this pull request Dec 9, 2024
[24.2] Fix workflow change stack broken with #19230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/workflows kind/bug kind/enhancement release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants