Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish Workflow Best Practices Panel #10989

Open
3 of 15 tasks
jmchilton opened this issue Dec 24, 2020 · 2 comments
Open
3 of 15 tasks

Polish Workflow Best Practices Panel #10989

jmchilton opened this issue Dec 24, 2020 · 2 comments

Comments

@jmchilton
Copy link
Member

jmchilton commented Dec 24, 2020

Tracking plans for second iteration of #10988

  • Check for invalid references - e.g referring to #{some_output}, when some_output is not a tool output?
  • Make sure parameters disappear from attributes after update.
  • Rename "Parameters" in Attributes panel Legacy Parameters and add "fa-magic" button to bring to linting panel.
  • Pre-catch more problems prior to extracting disconnected inputs and legacy parameters that would prevent refactoring.
    • mixed legacy on tool parameters
    • Update UI to tell why cannot fix (when canExtract is false)
  • Add another warning to fixAll button - this may be a big change to your workflow. 
  • Add preview of refactoring steps to fixAll button (starting to buildup a workflow diffing components based on refactoring actions).
  • Display creator and license in green dialog as INFO in green panel.
  • Allow embedded editing of creator and license.
  • Display valid inputs and outputs as INFO in green panel.
  • Highlight inputs and outputs in the workflow editor on mouseover in linting panel. (Implementing highlighting and scrolling to nodes in canvas from lint panel. #11025)
  • Button (or automatic) centering of the workflow editor on mouseover in linting panel. (Implementing highlighting and scrolling to nodes in canvas from lint panel. #11025)
  • Fix annotation editing ala Fixes for license and creator saving and updating. #10987 and uncomment from linting panel.
  • Allow embedded editing of annotation.
@jmchilton
Copy link
Member Author

There is a bug that needs to be fixed before the release is finalized where if steps are added or removed before the workflow is saved - the order_index the panel wants to apply is wrong.

@mvdbeek
Copy link
Member

mvdbeek commented Mar 10, 2021

There is a bug that needs to be fixed before the release is finalized where if steps are added or removed before the workflow is saved - the order_index the panel wants to apply is wrong.

I think that's fixed, but https://github.com/galaxyproject/galaxy/pull/11527/files#r586484668 still needs to be addressed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants