Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various improvements to various grids #15237

Closed
wants to merge 63 commits into from
Closed

various improvements to various grids #15237

wants to merge 63 commits into from

Conversation

martenson
Copy link
Member

rebase of #14514 with fixes

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@martenson martenson added this to the 23.0 milestone Dec 19, 2022
@martenson

This comment was marked as resolved.

Sign in to view
@martenson martenson modified the milestones: 23.0, 23.1 Jan 6, 2023
@jmchilton jmchilton mentioned this pull request Mar 28, 2023
Open
@martenson martenson force-pushed the grids-rebase branch 2 times, most recently from 004b1e6 to e3aa941 Compare April 26, 2023 18:47
jmchilton and others added 17 commits April 27, 2023 11:37
@jmchilton @martenson
Switch job index filtering to backend.
0bcfaf1 
Enables tagged search and will enable pagination in the future.
@jmchilton @martenson
Add effectiveFilter to filtersMixin...
9e884bf
@jmchilton @martenson
Allow viewing invocations for a history.
d7e794f
@jmchilton @martenson
Implement search tag to pages index API endpoint.
d63df36
@jmchilton @martenson
Use filtersMixin to improve Jobs index.
3553679
@jmchilton @martenson
Create tableProvider abstraction for paginationMixin.js.
9806a0e
@jmchilton @martenson
Page index components.
d6ee99c
@jmchilton @martenson
More de-duplication around grids...
31657ec
@jmchilton @martenson
Small improvements to published histories tests.
66abb8e
@jmchilton @martenson
Fix bug in published pages for anonymous users.
46ab232
@jmchilton @martenson
Outline published pages end-to-end tests.
ca17ed3
@jmchilton @martenson
Outline published workflows end-to-end tests.
1b6da42
@jmchilton @martenson
[WIP] Published grids in WorkflowList...
439faf4
@jmchilton @martenson
[WIP] Broken PageList component.
bb33008
@jmchilton @martenson
More test coverage for admin jobs table.
9a4de01
@jmchilton @martenson
Improved Selenium error message when Galaxy client fails to build.
a34445c
@martenson
fix path to jest helpers
17a510d
martenson added 24 commits April 27, 2023 11:37
@martenson
fix empty check on wf detail
a449adb
@martenson
disable anon copy menu
00e1ef4 
anon users cannot copy
@martenson
disable buttons that will fail for anons
db34a2d
@martenson
client format
fd4061c
@martenson
use pinia store instead of user provider
d412636
@martenson
remove currentuser call
8cfb737
@martenson
wait for user to be loaded before calling component
e996a08
@martenson
fix tests, mostly current user vs pinia related
2f1d830
@martenson
fix copy functionality on pageurl
482a87e
@martenson
disable sortin by owner
431fd4d 
until we figure out how to b-table sort things that have different names in frontend vs backend
@martenson
fix test, localize
74db239
@martenson
format
975665d
@martenson
unify clipboard string a bit
fade43c
@martenson
add page tags to schema and implement on grid
eed5922
@martenson
prettier
2dcfc8a
@martenson
cleanup, schema update
9824a06
@martenson
allow sorting on page title
e2be7c6
@martenson
rename itemsmodel var
96adf1e
@martenson
cleanup
50f8840
@martenson
update client api schema
ea32742
@martenson
testing "ReferenceError: fetch is not defined" on github
fd4fcb7
@martenson
fix mockfetcher by reordering imports
77e5305
@martenson
refactor fetcher mocking
b0ab910
@martenson
use new mock fetcher location and style
57b99b6
@mvdbeek
Copy link
Member

mvdbeek commented Apr 28, 2023

Can you break the PR out into smaller pieces ? It's getting tricky to review this all as a single thing.

This was referenced Apr 28, 2023
Merged
Merged
@martenson
Copy link
Member Author

implemented in

#16209
#16163
#16136
#16045
#16020

@martenson martenson closed this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/UI-UX kind/enhancement
Projects
None yet
Milestone
23.1
Development

Successfully merging this pull request may close these issues.
3 participants
@martenson @mvdbeek @jmchilton