implement admin jobs filtering #16020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
reviewed
May 2, 2023
jmchilton
reviewed
May 2, 2023
add forgotten files, format add more methods for selenium navigation add needed selectors jobs grid test: proper admin handling and wait for the workflow invocation blackened fix copypasta name Co-authored-by: John Chilton <[email protected]>
|
This is ready to go once the tests pass. The mixin refactoring can be treated independently from this PR. |
4 tasks
|
We should definitely make every effort to eliminate mixins as we modernize code, but especially given the context here, that it's being broken out of a larger project that you'll follow up on, I think this is fine. Thanks @martenson |
dannon
approved these changes
May 5, 2023
This was referenced Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulled out of #15237 in an effort to simplify things
needs to wait for #16017How to test the changes?
(Select all options that apply)
License