-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bring grids for (published) pages on par with workflows #16209
Conversation
Awesome - thanks so much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backend looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks great to me👍
I've reviewed the front-end changes and left some comments.
API test failures (due to deadlock) on first run were unrelated. |
the whole |
see galaxyproject#15774 for context update page =pdf export selenium test update return type to reflect matches being returned cleanup the test file run make format
This one fails for me locally. The |
setting values in the toolform fail even with d057da2 screenshots show just masthead rendered, browser log is empty, driver log is empty locally this works fine even with headless=0 and me watching it I'll look into it more tomorrow |
- drop the relevant jest tests since b-modal attaches outside of the wrapper and is not findable to my knowledge - could be likely replaced by a selenium test?
…ling this is what the actual component unit tests do see https://github.com/bootstrap-vue/bootstrap-vue/blob/dev/src/components/modal/modal.spec.js#L233
at this point I really don't know what's up with this test; I cannot reproduce it locally and the debug info from CI does not give me a clue any insights are very welcome |
I don't know why but the last CI run ran on an outdated code, referring the |
Conflicts: lib/galaxy_test/base/populators.py
add test_pages another attempt to please selenium deity with more waiting for no reason
When the Selenium tests pass locally but fail consistently in CI I always try to set an URL prefix like Also, when I get an empty page just with the masthead showing (since I now know it is a prefix-related issue), I look carefully at the URL and I usually find the reason :) The prefix got duplicated. |
Thank you, @martenson! |
this is waiting on #16163, will stay draft until thenpersonal grid
published grid
How to test the changes?
(Select all options that apply)
License