[TESTS] Run each test on multiple symbols and testing using a fixed list of symbols #51
Closed
5 tasks done
Comments
|
Hey @PythonCreator27, agree completely. Thanks for this! |
|
I tried expanding the symbols we use for testing by adding a couple of ones with little data, but unfortunately, the tests are now failing. This is a real issue - more in #57. |
gadicc
added a commit
that referenced
this issue
Feb 17, 2021
gadicc
added a commit
that referenced
this issue
Feb 17, 2021
gadicc
added a commit
that referenced
this issue
Feb 17, 2021
gadicc
added a commit
that referenced
this issue
Feb 17, 2021
gadicc
pushed a commit
that referenced
this issue
Feb 17, 2021
## [1.7.2](v1.7.1...v1.7.2) (2021-02-17) ### Bug Fixes * **browser:** mv fetchDevel to _env, fixes issues w/ `ng build` ([#50](#50)) ([7528580](7528580)) * **quote:** add additional properties ([4ab73c1](4ab73c1)) * **quote:** make certain properties optional ([1881bcb](1881bcb)) * **quote:** more optional properties ([#51](#51)) ([631ed45](631ed45)) * **quoteSummary:** more optionality, enum types, to fix tests ([#51](#51)) ([bc47bdf](bc47bdf)) * **types:** more optionality in quoteSummary,search for newer stocks ([b230635](b230635)) * **validate:** stricter nulls, number|null type, better errors ([#51](#51)) ([93dafc6](93dafc6)) * QuoteSummary & Search validation ([28f0487](28f0487))
gadicc
pushed a commit
that referenced
this issue
Feb 18, 2021
## [1.7.2](v1.7.1...v1.7.2) (2021-02-17) ### Bug Fixes * **browser:** mv fetchDevel to _env, fixes issues w/ `ng build` ([#50](#50)) ([7528580](7528580)) * **quote:** add additional properties ([4ab73c1](4ab73c1)) * **quote:** make certain properties optional ([1881bcb](1881bcb)) * **quote:** more optional properties ([#51](#51)) ([631ed45](631ed45)) * **quoteSummary:** more optionality, enum types, to fix tests ([#51](#51)) ([bc47bdf](bc47bdf)) * **types:** more optionality in quoteSummary,search for newer stocks ([b230635](b230635)) * **validate:** stricter nulls, number|null type, better errors ([#51](#51)) ([93dafc6](93dafc6)) * QuoteSummary & Search validation ([28f0487](28f0487))
gadicc
pushed a commit
that referenced
this issue
Feb 18, 2021
## [1.7.2](v1.7.1...v1.7.2) (2021-02-17) ### Bug Fixes * **browser:** mv fetchDevel to _env, fixes issues w/ `ng build` ([#50](#50)) ([7528580](7528580)) * **quote:** add additional properties ([4ab73c1](4ab73c1)) * **quote:** make certain properties optional ([1881bcb](1881bcb)) * **quote:** more optional properties ([#51](#51)) ([631ed45](631ed45)) * **quoteSummary:** more optionality, enum types, to fix tests ([#51](#51)) ([bc47bdf](bc47bdf)) * **types:** more optionality in quoteSummary,search for newer stocks ([b230635](b230635)) * **validate:** stricter nulls, number|null type, better errors ([#51](#51)) ([93dafc6](93dafc6)) * QuoteSummary & Search validation ([28f0487](28f0487))
|
Closing as task is done. |
|
Yayyyy 🎉 Thanks, @PythonCreator27. As I said in your PR, these were a massive help to me and of course all the other consumers of the library. So thanks again for all your time and effort here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running each
it()block on several symbolsRunning each
it()block on more symbols would definitely increase the accuracy of tests, as certain stocks return some things, and some don't.TODO
it.each()instead oftestSymbols.forEach()with extradescribeblocks (chore(tests): switch from using forEach to using it.each #53)symbols.tsfile (chore(tests): add more symbols to symbols.ts #58)it.each()instead ofit()alone (run tests on multiple symbols) everywhere (chore(tests): use it.each with testSymbols for several test suites #63, more coming)Benefits
We get added checking of validation, so we don't get things like #46 again. We can also check that the modules work properly for several different symbols.
The text was updated successfully, but these errors were encountered: