Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): switch from using forEach to using it.each #53

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

advaiyalad
Copy link
Contributor

@advaiyalad advaiyalad commented Feb 16, 2021

Ref #51
This PR switches from using the JS inbuilt forEach function to using the jest inbuilt it.each function for testing a test against multiple symbols.

Changes

  • Switch from testSymbols.forEach() to it.each(testSymbols)()
  • Add better names for tests using forEach

@gadicc
Copy link
Owner

gadicc commented Feb 16, 2021

That's great, thanks, @PythonCreator27! 🙏

@gadicc gadicc merged commit 116c5d8 into gadicc:devel Feb 16, 2021
@advaiyalad advaiyalad deleted the chore/switch-from-foreach-to-iteach branch February 16, 2021 15:37
@gadicc
Copy link
Owner

gadicc commented Feb 17, 2021

🎉 This PR is included in version 1.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants