-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move non-http code from FSharp.Data.Http into a new FSharp.Data.Runtime.Utilities project + Rearrange project files #1475
Conversation
The Windows build seems a bit flaky... It's currently failing because it couldn't properly download an rss feed in the docs fsx... Is there a way to simply retry it? |
@cartermp hey, thanks for taking a look! 🙏 I have a commit ready to shut-up the worldbank api-related test failures. You have just a word to say and I can add it to the branch of this PR! (if you want to take a look first: f1115e3) EDIT: ah, it seems there is another network-related error with the html provider docs -_- EDIT2: The html provider error is caused by the following difference when requesting the https://www.nuget.org/packages/FSharp.Data page 😩 |
Seeing "see inner exception in the message" without the inner exception is very frustrating!
17fd25d
to
7c41bbe
Compare
7c41bbe
to
8c3f4c6
Compare
Well, looks like the last build failure was a TLS version issue... For the record:
I'm not sure why it would not be enabled on the github windows runner, but adding TLS 1.2 to All in all, I added four commits to the branch to fix the build.
Adding I hope this is ok! |
Thanks @mlaily. There sure is a lot of ... "legacy behavior"... in here 🙂 |
closes #1468
For the record, I used the name suggested in the linked issue above for the new common project, but I feel like something like
FSharp.Data.Runtime.Common
might have been more appropriate.This is still an improvement over the current situation with everything in FSharp.Data.Http.
I also took the opportunity to rearrange source files into their respective project folders.
Files layout in the src folder should now mostly match the solution organisation.
This also has the nice side effect of making folders reappear in Visual Studio. (for some reason, files included in projects but living outside the project's folder appear as a flat list of linked files in this IDE)
The complete diff is ugly, but reviewing individual commits should be more comfortable.