Fix generated code of the json provider with PreferDictionaries
when values are arrays
#1476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the generation is wrong:
This is because the records inferred originally in the arrays are normally supposed to have the name of the property declaring them (
123
and789
in the screenshots), and two similar records with a different name are not merged.This problem was taken care of by the original
PreferDictionaries
implementation when values are records (by dropping the record's name), but not when the values are arrays of records!After this PR, the names of records nested in an array are also dropped, which yields the expected result, with records properly merged in a single type:
(PR of the original implementation for reference: #1430)
Note: This PR contains only 2 commits, but is currently on top of the
rearrange-project-files
branch, from #1475 — I will rebase it onmaster
when #1475 is merged.EDIT: rebased and ready!