-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why are the core features (CommonRuntime
folder) implemented in the Http project?
#1468
Comments
Hmm, yeah, offhand I'd say these don't have any business being in that project, since it's just HTTP utilities really. |
Part of this is related to whether we spilt the type providers out. Until we do that and decide on naming for that, I felt it wasn't much point in having a |
Hmm ok, I see. Too bad it's called I was very surprised when debugging the providers from a script by referencing the dlls explicitly and it didn't work until I referenced Maybe this is only really an issue for debugging like this though... Do you see the current situation as something that will have to change before the next release, or do you plan to keep it like that until the providers are split out? (if it ever happens) Would an attempt to move the types necessary for the providers into the I'm willing to help but I don't know in which direction we want to go... |
FSharp.Data should remain an empty shell, that was kind of the point of splitting things up. I think you could try moving them to a new FSharp.Data.Runtime.Utilties. I'd have no direct problem with that - however there may be devil in the detail (e.g. if the Http part depends on some of them) |
Ok, thanks. I took a look and maybe you already had it in mind, but it seems the first difficulty is that most if not all the providers depend on the http implementation (if only for their Extracting a new Would simply renaming the |
Yes people want the Http part alone - part of the point in splitting things out was to make that available as a nuger package |
It looks like an oversight made during the split in multiple projects?
https://github.com/fsprojects/FSharp.Data/blob/main/src/FSharp.Data.Http/FSharp.Data.Http.fsproj#L15-L22
It would seem more logical for these files to be in
FSharp.Data.DesignTime
, or in a new dedicated Core project.What do you think?
The text was updated successfully, but these errors were encountered: