Improve gazebo hand/finger collision behavoir #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickstaa
force-pushed
the
improve_gazebo_hand_collision_geometries
branch
from
8d099f9 to
0ac476c
Compare
rickstaa
changed the title
This was referenced Aug 13, 2021
rickstaa
force-pushed
the
improve_gazebo_hand_collision_geometries
branch
4 times, most recently
from
0668131 to
29f08f4
Compare
rickstaa
force-pushed
the
improve_gazebo_hand_collision_geometries
branch
from
29f08f4 to
e2e3bfd
Compare
This was referenced Oct 6, 2021
|
Hi @rickstaa If you could add the CHANGELOG entry this PR will be ready to be merged. |
…ption This commit replaces the hand/finger collision geometries that are used in the Gazebo robot description with more accurate meshes. These meshes were taken from [AndrejOrsula/panda_ign](https://github.com/AndrejOrsula/panda_ign/blob/master/panda/meshes/collision/finger.stl).
rickstaa
force-pushed
the
improve_gazebo_hand_collision_geometries
branch
from
e2e3bfd to
7327078
Compare
|
@falfab Thanks for accepting my pull request! I applied the changes you requested. I also merged the two commits into one clean commit. Feel free to request any other changes. |
rickstaa
added a commit
to rickstaa/franka_ros
that referenced
this pull request
Oct 18, 2021
This commit fixes a bug that was introduced by frankaemika#147. In frankaemika#147 the finger collision geometries were replaced by more accurate meshes. These more accurate messages however broke the 'gripper_action' action. This commit migrates back to using geomteries for the finger collision goeometries. The action server works fine when geometries are used.
rickstaa
added a commit
to rickstaa/franka_ros
that referenced
this pull request
Oct 18, 2021
This commit fixes a bug that was introduced by frankaemika#147. In frankaemika#147 the finger collision geometries were replaced by more accurate meshes. These more accurate messages however broke the 'gripper_action' action. This commit migrates back to using geomteries for the finger collision goeometries. The action server works fine when geometries are used.
rickstaa
added a commit
to rickstaa/franka_ros
that referenced
this pull request
Oct 18, 2021
This commit fixes a bug that was introduced by frankaemika#147. In frankaemika#147 the finger collision geometries were replaced by more accurate meshes. These more accurate messages however broke the 'gripper_action' action. This commit migrates back to using geometries for the finger collision geometries. The action server works fine when geometriesare used.
rickstaa
added a commit
to rickstaa/franka_ros
that referenced
this pull request
Oct 18, 2021
This commit fixes a bug that was introduced by frankaemika#147. In frankaemika#147 the finger collision geometries were replaced by more accurate meshes. These more accurate messages however broke the 'gripper_action' action. This commit migrates back to using geometries for the finger collision geometries. The action server works fine when geometriesare used.
rickstaa
added a commit
to rickstaa/franka_ros
that referenced
this pull request
Oct 20, 2021
This commit fixes a bug that was introduced by frankaemika#147. In frankaemika#147 the finger collision geometries were replaced by more accurate meshes. These more accurate messages however broke the 'gripper_action' action. This commit migrates back to using geometries for the finger collision geometries. The action server works fine when geometriesare used.
rickstaa
added a commit
to rickstaa/franka_ros
that referenced
this pull request
Oct 20, 2021
This commit fixes a bug that was introduced by frankaemika#147. In frankaemika#147 the finger collision geometries were replaced by more accurate meshes. These more accurate messages however broke the 'gripper_action' action. This commit migrates back to using geometries for the finger collision geometries. The action server works fine when geometriesare used.
m-elwin
pushed a commit
to m-elwin/franka_ros
that referenced
this pull request
Oct 25, 2021
This commit fixes a bug that was introduced by frankaemika#147. In frankaemika#147 the finger collision geometries were replaced by more accurate meshes. These more accurate messages however broke the 'gripper_action' action. This commit migrates back to using geometries for the finger collision geometries. The action server works fine when geometriesare used.
rickstaa
added a commit
to rickstaa/franka_ros
that referenced
this pull request
Oct 28, 2021
This commit fixes a bug that was introduced by frankaemika#147. In frankaemika#147 the finger collision geometries were replaced by more accurate meshes. These more accurate messages however broke the 'gripper_action' action. This commit migrates back to using geometries for the finger collision geometries. The action server works fine when geometriesare used.
falfab
added a commit
that referenced
this pull request
Nov 5, 2021
…kins-script-must-fail-when-internal to develop * commit 'f8506671ea911c35f6c5794d8d8a7c326f903f20': Modified checkgithistory to accept parameters and fixed typos in comment Checking github history sync in separate jenkins stage and removed unused dependency from dockerfile Add: bash script to check sync between local and public repos
tahsinkose
pushed a commit
to tahsinkose/franka_ros
that referenced
this pull request
Nov 11, 2021
This commit fixes a bug that was introduced by frankaemika#147. In frankaemika#147 the finger collision geometries were replaced by more accurate meshes. These more accurate messages however broke the 'gripper_action' action. This commit migrates back to using geometries for the finger collision geometries. The action server works fine when geometriesare used.
rickstaa
added a commit
to rickstaa/franka_ros
that referenced
this pull request
Nov 22, 2021
This commit fixes a bug that was introduced by frankaemika#147. In frankaemika#147 the finger collision geometries were replaced by more accurate meshes. These more accurate messages however broke the 'gripper_action' action. This commit migrates back to using geometries for the finger collision geometries. The action server works fine when geometriesare used.
rickstaa
added a commit
to rickstaa/franka_ros
that referenced
this pull request
Nov 23, 2021
This commit fixes a bug that was introduced by frankaemika#147. In frankaemika#147 the finger collision geometries were replaced by more accurate meshes. These more accurate messages however broke the 'gripper_action' action. This commit migrates back to using geometries for the finger collision geometries. The action server works fine when geometriesare used.
rickstaa
added a commit
to rickstaa/franka_ros
that referenced
this pull request
Nov 23, 2021
This commit fixes a bug that was introduced by frankaemika#147. In frankaemika#147 the finger collision geometries were replaced by more accurate meshes. These more accurate messages however broke the 'gripper_action' action. This commit migrates back to using geometries for the finger collision geometries. The action server works fine when geometriesare used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the Gazebo collision geometries.
Old collision geometries
New collision geometries