Updates state_publisher to robot_state_publisher in the franka_visualization package #137
Conversation
|
Would be great if this fix could go in! Thanks a lot |
rickstaa
force-pushed
the
fix_franka_visualization_robot_state_publisher_error
branch
from
baa0328 to
44a0cdd
Compare
|
@domire8 I just rebased it onto the noetic-devel so that the @frankaemika team can easily merge it. |
…very_behavior to develop * commit '6172dcfde9dc8ff9cc9a947d2064d947a35cb047': fix typo in doc cmake version 3.1.3 in meta package franka_ros for melodic and noetic support make recovery print debug reset command buffer on recover, keep updating while in reflex remove redundant . in print revert cmake version update in meta package to fix build issue with catkin_make only execute controller update when not in error state
|
Hi @rickstaa, don't worry, we didn't forget you ;) Thanks in advance for all your effort which you put into making Before we merge anything, though, please be a little bit more patient until we have a proper CI set up with Github actions. |
|
@gollth No problem, thanks for having such an active development and allowing pull requests. Take your time for my research, I'm currently working from my own branches. |
|
@gollth Also feel free to tag me if you need information or changes on any of my pull request. |
|
Could you rebase this branch to latest develop please? |
rickstaa
force-pushed
the
fix_franka_visualization_robot_state_publisher_error
branch
from
44a0cdd to
860ae7b
Compare
|
@gollth done. |
|
O |
This commit removes the depricated 'state_publisher' alias and replaces it with the new 'robot_state_publisher'. See ros/robot_state_publisher#87.
rickstaa
force-pushed
the
fix_franka_visualization_robot_state_publisher_error
branch
from
860ae7b to
e5405c9
Compare
|
@gollth Now it is rebased onto the |
|
Our CI seems to work now =) I tested on melodic and looks good. Thanks for fixing! |
rickstaa
deleted the
fix_franka_visualization_robot_state_publisher_error
branch
This commit removes the deprecated 'state_publisher' alias and replaces it with the new 'robot_state_publisher'. See
ros/robot_state_publisher#87.