Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spell configuration to ItemGrant advancement #1626

Closed
arbron opened this issue Jul 3, 2022 · 0 comments · Fixed by #1690
Closed

Add spell configuration to ItemGrant advancement #1626

arbron opened this issue Jul 3, 2022 · 0 comments · Fixed by #1690

Comments

@arbron
Copy link
Collaborator

arbron commented Jul 3, 2022

The advancements for granting (#1400) and choosing items (#1401) should have the option to modify any spells added:

  • Select preparation mode (regular, always prepared, pact magic, at will, innate)
  • Change limited uses
  • Specify spellcasting ability

These options should be part of these advancements, but the controls should only be visible if a spell is added to an Item Grant advancement or the "Spell" type is selected in an Item Choice advancement.

The interface would be similar to this mockup by @MaxPat931

image

The configuration for these advancement types would gain something like this:

{
  configuration: {
    spells: {
      ability: null,          // Don't change the spellcasting ability
      preparation: "innate",  // Set to innate spellcasting
      uses: {
        max: "1",
        per: "lr"             // One casting per long rest
      }
    }
  }
}
@arbron arbron added this to the D&D5E 1.7.0 milestone Jul 3, 2022
@arbron arbron self-assigned this Jul 3, 2022
@arbron arbron linked a pull request Jul 3, 2022 that will close this issue
@arbron arbron modified the milestones: D&D5E 2.0.0, D&D5E 2.1.0 Jul 26, 2022
@arbron arbron changed the title Add spell configuration to ItemGrant & ItemChoice advancements Add spell configuration to ItemGrant advancement Aug 7, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Aug 7, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Aug 7, 2022
…& type restriction to ItemGrant advancement
arbron added a commit to arbron/dnd5e that referenced this issue Aug 7, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Aug 22, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Aug 22, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Aug 22, 2022
…hoice pool if type restriction or spell level are changed
arbron added a commit to arbron/dnd5e that referenced this issue Aug 22, 2022
…hoice pool if type restriction or spell level are changed
arbron added a commit to arbron/dnd5e that referenced this issue Aug 22, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Aug 22, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Aug 22, 2022
…hoice pool if type restriction or spell level are changed
arbron added a commit to arbron/dnd5e that referenced this issue Aug 27, 2022
…& type restriction to ItemGrant advancement
arbron added a commit to arbron/dnd5e that referenced this issue Aug 27, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Aug 27, 2022
@arbron arbron modified the milestones: D&D5E 2.1.0, D&D5E 2.0.0 Aug 27, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Sep 9, 2022
…DroppedItem, remove async requirement from ItemGrantConfig#getData
Fyorl pushed a commit that referenced this issue Sep 10, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Sep 10, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Sep 10, 2022
…hoice pool if type restriction or spell level are changed
arbron added a commit to arbron/dnd5e that referenced this issue Oct 8, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 8, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 8, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 8, 2022
…hoice pool if type restriction or spell level are changed
arbron added a commit to arbron/dnd5e that referenced this issue Oct 8, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 8, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 8, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 8, 2022
…hoice pool if type restriction or spell level are changed
arbron added a commit to arbron/dnd5e that referenced this issue Oct 18, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 18, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 18, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 18, 2022
…hoice pool if type restriction or spell level are changed
arbron added a commit to arbron/dnd5e that referenced this issue Oct 19, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 19, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 19, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 19, 2022
…hoice pool if type restriction or spell level are changed
arbron added a commit to arbron/dnd5e that referenced this issue Dec 21, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Dec 21, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Dec 21, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Dec 21, 2022
…hoice pool if type restriction or spell level are changed
arbron added a commit to arbron/dnd5e that referenced this issue Dec 29, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Dec 29, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Dec 29, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Dec 29, 2022
…hoice pool if type restriction or spell level are changed
arbron added a commit to arbron/dnd5e that referenced this issue Dec 30, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Dec 30, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Dec 30, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Dec 30, 2022
…hoice pool if type restriction or spell level are changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment