-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1620, #1626, #1689] Add spell config & type restriction to ItemGrant advancement #1690
Merged
Fyorl
merged 4 commits into
foundryvtt:2.0.x
from
arbron:advancement/item-grant-improvements
Sep 10, 2022
Merged
[#1620, #1626, #1689] Add spell config & type restriction to ItemGrant advancement #1690
Fyorl
merged 4 commits into
foundryvtt:2.0.x
from
arbron:advancement/item-grant-improvements
Sep 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 7, 2022
aaclayton
requested changes
Aug 27, 2022
…& type restriction to ItemGrant advancement
…ve development logging
arbron
force-pushed
the
advancement/item-grant-improvements
branch
from
August 27, 2022 15:51
2511970
to
c17285c
Compare
Fyorl
requested changes
Sep 9, 2022
…DroppedItem, remove async requirement from ItemGrantConfig#getData
Fyorl
approved these changes
Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
class
,subclass
, orbackground
items from being added using item grant to avoid issues caused by the use of the advancement system in a way that isn't yet supported (existing advancements that do this won't break, but new ones can't be created through the interface) (resolves PreventItemGrantAdvancement
from adding classes, subclasses, or backgrounds #1689)AdvancementConfig
to prepare for sharing withItemChoiceAdvancement