Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front end i18n updates #1054

Merged
merged 3 commits into from
Oct 21, 2018
Merged

Front end i18n updates #1054

merged 3 commits into from
Oct 21, 2018

Conversation

seanmcn
Copy link
Contributor

@seanmcn seanmcn commented Oct 3, 2018

Resolves #1000 adding in the suggested translation in French, the rest with Google Translate..

Adds variables in a number of other places on the front-end where there is hardcoded English.

Happy #hacktoberfest 😄

@jtojnar
Copy link
Member

jtojnar commented Oct 5, 2018

Thank you very much for your contribution.

  1. Could you make it so that the error messages’ ids start with error_?
  2. Adding the commented out translations might confuse the translation website (coming soon). Could you remove the commit?

@Binnette do you think you could check the French translations?

@jtojnar jtojnar added this to the 2.19 milestone Oct 5, 2018
@jtojnar jtojnar added the i18n label Oct 5, 2018
@seanmcn
Copy link
Contributor Author

seanmcn commented Oct 6, 2018

Have made the requested changes, let me know if you need anything else from me on this. 😄

@seanmcn seanmcn changed the title Front end I18n updates Front end i18n updates Oct 6, 2018
@jtojnar
Copy link
Member

jtojnar commented Oct 6, 2018

I think the colons should go to the translations too – some languages might use different punctuation. (Or, in case of French, add a thin space before them.)

public/js/selfoss-events.js Outdated Show resolved Hide resolved
public/lang/fr.ini Outdated Show resolved Hide resolved
@Binnette
Copy link
Contributor

Binnette commented Oct 20, 2018

Done ! I just reviewed french string and I made a pull request in @seanmcn repo : seanmcn#1

2 strings were missing in fr.ini :

  • lang_error_mark_item
  • lang_error_star_item

Can you please chek that those 2 strings are not missing in other files ?
See you 😉

@jtojnar jtojnar merged commit 09f5a08 into fossar:master Oct 21, 2018
@jtojnar
Copy link
Member

jtojnar commented Oct 21, 2018

Thank you both.

@jtojnar
Copy link
Member

jtojnar commented Sep 27, 2020

Hi @seanmcn and @Binnette. Previously, it was not clear if selfoss was licensed under GPL 3 only, or also any later version. Could you clarify whether you are fine with licensing your contribution under GPL-3-or-later?

Thanks again and sorry for the confusion.

@seanmcn
Copy link
Contributor Author

seanmcn commented Sep 27, 2020

@jtojnar fine with me 👍

@Binnette
Copy link
Contributor

Of course @jtojnar 👍 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messages hard-coded in english in js
3 participants