Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New GF Checks: Ensure VFs conform to GF axis registry #3022

Closed
m4rc1e opened this issue Aug 24, 2020 · 7 comments
Closed

New GF Checks: Ensure VFs conform to GF axis registry #3022

m4rc1e opened this issue Aug 24, 2020 · 7 comments
Assignees
@m4rc1e
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P0 Urgent
Milestone
0.7.32

Comments

@m4rc1e
Copy link
Collaborator

m4rc1e commented Aug 24, 2020

So we've now got a Google Fonts axis registry. We need to make sure that variable fonts intended for Google Fonts follow it, otherwise the fonts won't get pushed.

Off the top of my head, we can use it to make the following checks:

  • Flag a WARN if a VF includes an axis which is not part of the registry
  • Check VF's axes ranges are within the allowed ranges specified in each axis registry.
  • Check that instance/STAT particle names match the fallback names in each axis registry.

Nate may move the axis registry to its own repo. We can then submodule it in this repo and google/fonts.
@felipesanches felipesanches added the New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id label Aug 24, 2020
@davelab6 davelab6 added this to the 0.7.32 milestone Oct 1, 2020
@davelab6
Copy link
Contributor

davelab6 commented Oct 1, 2020

google/fonts#2675 was merged but should not have been, because this check was not yet implemented, so tagging as P0 for next release :)

@davelab6
Copy link
Contributor

davelab6 commented Oct 1, 2020

Those 3 checks are good and should FAIL not WARN.

felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 1, 2020
@felipesanches
A couple new checks for the GF Axis Registry
55afc2c 
- **[com.google.fonts/check/metadata/gf-axisregistry_valid_tags]:** VF axis tags are registered on GF Axis Registry (issue fonttools#3010)
- **[com.google.fonts/check/metadata/gf-axisregistry_bounds]:** VF axes have ranges compliant to the bounds specified on the GF Axis Registry (issue fonttools#3022)
@felipesanches felipesanches mentioned this issue Oct 1, 2020
Merged
felipesanches added a commit that referenced this issue Oct 1, 2020
@felipesanches
A couple new checks for the GF Axis Registry
f005186 
- **[com.google.fonts/check/metadata/gf-axisregistry_valid_tags]:** VF axis tags are registered on GF Axis Registry (issue #3010)
- **[com.google.fonts/check/metadata/gf-axisregistry_bounds]:** VF axes have ranges compliant to the bounds specified on the GF Axis Registry (issue #3022)
@felipesanches
Copy link
Collaborator

@davelab6, one of the checks here was also suggested at #3010, and was implemented as com.google.fonts/check/metadata/gf-axisregistry_valid_tags "VF axis tags are registered on GF Axis Registry" on PR #3050

Another one, com.google.fonts/check/metadata/gf-axisregistry_bounds "VF axes have ranges compliant to the bounds specified on the GF Axis Registry", was also added in that same PR that I have just merged.

Now we still have to work on the third one, which I'll probably call com.google.fonts/check/STAT/gf-axisregistry_names

felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 7, 2020
@felipesanches
We now keep a local copy of the Google Fonts Axis Registry textproto …
7e84ebf 
…files

so that the checks do not need to keep always fetch them online at runtime.
These files should not change too often, but we should be careful to check for updates on our FontBakery releases.
(issue fonttools#3022)
@felipesanches felipesanches mentioned this issue Oct 7, 2020
Merged
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 7, 2020
@felipesanches
We now keep a local copy of the Google Fonts Axis Registry textproto …
b83453f 
…files

so that the checks do not need to keep always fetch them online at runtime.
These files should not change too often, but we should be careful to check for updates on our FontBakery releases.
(issue fonttools#3022)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 7, 2020
@felipesanches
We now keep a local copy of the Google Fonts Axis Registry textproto …
4d77c28 
…files

so that the checks do not need to keep always fetch them online at runtime.
These files should not change too often, but we should be careful to check for updates on our FontBakery releases.
(issue fonttools#3022)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 7, 2020
@felipesanches
We now keep a local copy of the Google Fonts Axis Registry textproto …
2bcfee6 
…files

so that the checks do not need to keep always fetch them online at runtime.
These files should not change too often, but we should be careful to check for updates on our FontBakery releases.
(issue fonttools#3022)
felipesanches added a commit that referenced this issue Oct 7, 2020
@felipesanches
We now keep a local copy of the Google Fonts Axis Registry textproto …
ce0af11 
…files

so that the checks do not need to keep always fetch them online at runtime.
These files should not change too often, but we should be careful to check for updates on our FontBakery releases.
(issue #3022)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 7, 2020
@felipesanches
Check that particle names on STAT table match the fallback names...
1af8a12 
...in each axis registry at the Google Fonts Axis Registry
(issue fonttools#3022)
@felipesanches felipesanches mentioned this issue Oct 7, 2020
Merged
@felipesanches felipesanches assigned m4rc1e and unassigned felipesanches Oct 7, 2020
@felipesanches
Copy link
Collaborator

@m4rc1e I need some feedback from you to make sure the current implementation at the pull request #3056 is indeed what you expected. Please reassign the issue to me if you approve that implementation, so that I can implement the code-test and then merge it.

@felipesanches
Copy link
Collaborator

In particular, I have this question:

"Check that instance/STAT particle names match the fallback names in each axis registry"
Should only names of axis coordinates match the registry? Or should we also enforce their values?

In my initial implementation I check for both things.

felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 12, 2020
@felipesanches
wip: addressing some issues pointed out by @m4rc1e at PR fonttools#3056
e265a0d 
(issue fonttools#3022)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 12, 2020
@felipesanches
Check that particle names on STAT table match the fallback names...
82fcb53 
...in each axis registry at the Google Fonts Axis Registry
(issue fonttools#3022)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 12, 2020
@felipesanches
addressing some issues pointed out by @m4rc1e at PR fonttools#3056
ba922f5 
(issue fonttools#3022)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 14, 2020
@felipesanches
Adding code-tests for com.google.fonts/check/STAT/gf-axisregistry
2b23163 
(issue fonttools#3022)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 14, 2020
@felipesanches
Check that particle names on STAT table match the fallback names...
82170e4 
...in each axis registry at the Google Fonts Axis Registry
(issue fonttools#3022)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 14, 2020
@felipesanches
addressing some issues pointed out by @m4rc1e at PR fonttools#3056
200269a 
(issue fonttools#3022)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 14, 2020
@felipesanches
Adding code-tests for com.google.fonts/check/STAT/gf-axisregistry
a613e44 
(issue fonttools#3022)
felipesanches added a commit that referenced this issue Oct 15, 2020
@felipesanches
Check that particle names on STAT table match the fallback names...
cf2f385 
...in each axis registry at the Google Fonts Axis Registry
(issue #3022)
felipesanches added a commit that referenced this issue Oct 15, 2020
@felipesanches
addressing some issues pointed out by @m4rc1e at PR #3056
469be4f 
(issue #3022)
felipesanches added a commit that referenced this issue Oct 15, 2020
@felipesanches
Adding code-tests for com.google.fonts/check/STAT/gf-axisregistry
963bcbf 
(issue #3022)
@davelab6
Copy link
Contributor

@felipesanches is google/fonts#2772 prevented by the latest FB?

@yanone
Copy link
Collaborator

yanone commented Oct 29, 2020

Positive, I just checked.

@kateliev kateliev mentioned this issue Aug 7, 2024
Closed
@tphinney tphinney mentioned this issue Aug 8, 2024
Closed
@kateliev kateliev mentioned this issue Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m4rc1e m4rc1e

Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P0 Urgent
Projects
None yet
Milestone
0.7.32
Development

No branches or pull requests
4 participants
@yanone @felipesanches @davelab6 @m4rc1e