Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default axis value names need to match Google specs #348

Closed
tphinney opened this issue Aug 8, 2024 · 2 comments
Closed

Default axis value names need to match Google specs #348

tphinney opened this issue Aug 8, 2024 · 2 comments
Assignees
@tphinney
Labels
FontBakery Fail or Error from FontBakery tests next build

Comments

@tphinney
Copy link
Collaborator

tphinney commented Aug 8, 2024

Change names of defaults for axes as follows:

YOPQ: Regular > Normal
slnt: Regular > Default
slnt: Oblique > ? (NOT Default! Not sure we can support Slanted instances among the default instances?)
wdth: Regular > Normal

Validate STAT particle names and values match the fallback names in GFAxisRegistry.
Check ID: FontBakeryCheck:com.google.fonts/check/STAT/gf_axisregistry
Check that particle names and values on STAT table match the fallback names in each axis entry at the Google Fonts Axis Registry, available at https://github.com/google/fonts/tree/main/axisregistry

Original proposal: fonttools/fontbakery#3022
🔥 ScienceGothic[YOPQ,slnt,wdth,wght].ttf
🔥 FAIL
On the font variation axis 'YOPQ', the name 'Regular' is not among the expected ones (Normal) according to the Google Fonts Axis Registry.

[code: invalid-name]
🔥 FAIL
On the font variation axis 'slnt', the name 'Oblique' is not among the expected ones (Default) according to the Google Fonts Axis Registry.

[code: invalid-name]
🔥 FAIL
On the font variation axis 'slnt', the name 'Regular' is not among the expected ones (Default) according to the Google Fonts Axis Registry.

[code: invalid-name]
🔥 FAIL
On the font variation axis 'wdth', the name 'Regular' is not among the expected ones (SuperCondensed, UltraCondensed, ExtraCondensed, Condensed, SemiCondensed, Normal, SemiExpanded, Expanded, ExtraExpanded, UltraExpanded) according to the Google Fonts Axis Registry.

[code: invalid-name]
@tphinney tphinney added the FontBakery Fail or Error from FontBakery tests label Aug 8, 2024
@tphinney tphinney self-assigned this Aug 8, 2024
kateliev added a commit that referenced this issue Aug 20, 2024
@kateliev
Issue #348: Default axis value names need to match Google specs:
da03ce4 
Changed
- YOPQ: Regular to (Normal)
- slnt: Regular to (Default)
- wdth: Regular to (Normal)
- wgth: Regular stays (Regular)
@kateliev
Copy link
Member

Changed!.. but slnt: Oblique > ? (NOT Default! Not sure we can support Slanted instances among the default instances?) will keep it as it is for now.

@kateliev kateliev moved this from Done but not built to To do in Science Gothic VF Dec 3, 2024
@kateliev
Copy link
Member

kateliev commented Dec 3, 2024

Duplicate #357 fixed in c4df5e9

@kateliev kateliev closed this as completed Dec 3, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Science Gothic VF Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tphinney tphinney

Labels
FontBakery Fail or Error from FontBakery tests next build
Projects
Science Gothic VF
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tphinney @kateliev