Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is Newsreader OpSz min really 6? #2772

Closed
davelab6 opened this issue Oct 27, 2020 · 3 comments
Closed

Is Newsreader OpSz min really 6? #2772

davelab6 opened this issue Oct 27, 2020 · 3 comments

Comments

@davelab6
Copy link
Member

This 0 value should not have been accepted, and has been set to the axis minimum here, 6

92ec7cb

Originally posted by me at #2577 (comment)

@yanone is that the correct value?
@davelab6 davelab6 mentioned this issue Oct 27, 2020
Closed
@felipesanches
Copy link
Collaborator

felipesanches commented Oct 27, 2020 •
edited
Loading

yes, FontBakery detects this problem nowadays:

Screenshot from 2020-10-27 08-19-27

But this family was added back at 4d442fa last July 29 when we still did not have these checks on Font Bakery.

We also have a few more problems in this font detected by a recently implemented FB check:
Screenshot from 2020-10-27 08-22-45

@yanone
Copy link
Collaborator

yanone commented Oct 29, 2020

I'm tackling this, but I want to point out that you're looking at the wrong PR, which got "blocked".
The current one is here: #2661

@RosaWagner
Copy link
Contributor

I close this since it is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yanone @felipesanches @davelab6 @RosaWagner