[flytepropeller] Add tests in v1alpha #5896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DenChenn <[email protected]>
Signed-off-by: DenChenn <[email protected]>
Signed-off-by: DenChenn <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5896 +/- ##
==========================================
+ Coverage 34.96% 36.85% +1.89%
==========================================
Files 1143 1309 +166
Lines 122098 130895 +8797
==========================================
+ Hits 42688 48241 +5553
- Misses 75721 78472 +2751
- Partials 3689 4182 +493
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
DenChenn
force-pushed
the
flytepropeller-pkg-apis-flyteworkflow-test
branch
from
306bc12 to
d7e21cb
Compare
Signed-off-by: DenChenn <[email protected]>
DenChenn
force-pushed
the
flytepropeller-pkg-apis-flyteworkflow-test
branch
from
d7e21cb to
49ccd36
Compare
DenChenn
changed the title
pingsutw
approved these changes
Nov 7, 2024
Future-Outlier
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Love you!
Let's collaborate when you back from military service.
@DenChenn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Example: Related to #4209
Why are the changes needed?
Improve code tests coverage.
Check all the applicable boxes
Screenshots
Related PRs
#4234