Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Improve Test Coverage #4209

Closed
2 tasks done
pingsutw opened this issue Oct 12, 2023 · 4 comments · Fixed by #4234, #4237 or #4276
Closed
2 tasks done

[Housekeeping] Improve Test Coverage #4209

pingsutw opened this issue Oct 12, 2023 · 4 comments · Fixed by #4234, #4237 or #4276
Assignees
Labels
hacktoberfest housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@pingsutw
Copy link
Member

pingsutw commented Oct 12, 2023

Describe the issue

The test coverage of some components is low. We should add more tests to Flyte repo.
Creating multiple PRs to fix it is fine since it cannot be done in one PR.

image

What if we do not do this?

Test Coverage > 80%

Related component(s)

https://app.codecov.io/gh/flyteorg/flyte

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@pingsutw pingsutw added housekeeping Issues that help maintain flyte and keep it tech-debt free hacktoberfest labels Oct 12, 2023
@sohamtembhurne
Copy link

Hi @pingsutw,
Can you please elaborate on the issue ?

@pingsutw
Copy link
Member Author

@sohamtembhurne we need to add more tests to Flyte repo. For example, we need to add a test for this file.

@u5surf
Copy link

u5surf commented Oct 14, 2023

@pingsutw Hi, I'm interesting in this issue but it is a bit wide to make all directories improved the coverage. Can we split issue or task per directory? Hence, I would do some tasks after you decide to split the task.

@Future-Outlier
Copy link
Member

@u5surf You just have to add the test, create the PR, and mention this issue.
You can refer to this issue: #3936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment